Repository navigation
fix(fetch): reject Office documents as raw downloads - #1433
Merged
Merged
Conversation
ldm0
self-requested a review
October 12, 2026 09:19
Sequential Navigation Soak A/B✅ HEAD completed the 200-navigation resilience and memory observation. One browser process, one target, and one CDP session navigate CSDN → SegmentFault → Huaban → example.com repeatedly. This run issued 200 Common ancestor Session resilience
A public-page failure is reported separately from an unrecoverable session. The soak requires all navigation attempts, zero failed recovery, zero lifecycle/network ordering violations, and complete resource evidence. Process-tree memory
HEAD memory by 50-navigation quarter
Raw reports and per-navigation boundary samples: workflow run and full Public-site timing and memory are observational. Use the A/B deltas and trend shape as evidence, not as a deterministic performance threshold. |
Spider Bench A/B✅ All benchmark browser service runs completed; results are informational. Public HEAD: 179 / 240 rows; 37 / 48 sites produced rows; 11 unexpected empty sites. ✅ Deterministic fixture contract is clean. Common ancestor Public 48-site run · informational
Public-site content, timing, and memory are noisy. This single A/B run reports evidence only; site outcome counts explain missing rows without treating them as a deterministic regression. CPU and memory timelinesThese are bounded 40-point views of the same complete process-tree samples used by the HTML report. CPU uses 100% per occupied logical core; memory lines are RSS first and PSS second when complete PSS samples are available. Basexychart-beta
title "Base CPU"
x-axis "Elapsed seconds" [1.538, 2.54, 3.041, 4.544, 6.047, 7.549, 9.052, 9.553, 10.555, 12.056, 13.558, 15.059, 16.561, 18.063, 19.565, 21.067, 22.569, 24.07, 25.573, 27.074, 28.075, 29.577, 31.079, 32.581, 33.582, 34.082, 35.585, 37.087, 38.589, 40.091, 41.593, 43.094, 44.596, 46.098, 47.6, 49.103, 50.606, 52.108]
y-axis "CPU percent" 0 --> 200
line [31.99, 133.78, 141.73, 93.77, 137.69, 161.89, 93.85, 189.46, 137.79, 115.91, 173.72, 59.94, 33.97, 0, 5.99, 85.93, 19.97, 2, 3.99, 2, 0, 133.87, 105.92, 151.82, 99.9, 117.87, 139.68, 171.54, 65.91, 109.8, 165.78, 93.83, 2, 99.81, 13.97, 127.71, 71.89, 15.97]
xychart-beta
title "Base memory: RSS then PSS"
x-axis "Elapsed seconds" [0.038, 1.538, 2.54, 3.041, 4.544, 6.047, 7.549, 9.052, 9.553, 10.555, 12.056, 13.558, 15.059, 16.561, 18.063, 19.565, 21.067, 22.569, 24.07, 25.573, 27.074, 28.075, 29.577, 31.079, 32.581, 33.582, 34.082, 35.585, 37.087, 38.589, 40.091, 41.593, 43.094, 44.596, 46.098, 47.6, 49.103, 50.606, 52.108, 53.482]
y-axis "Memory MiB" 0 --> 500
line [12.54, 89.77, 127.66, 140.4, 122.61, 171.54, 182.54, 191.21, 187.54, 155.14, 180.14, 175.92, 163.05, 146.91, 148.37, 148.73, 174.85, 140.97, 142.89, 139.09, 139.14, 139.24, 156.15, 156.8, 159.6, 271.36, 259.6, 208.01, 226.57, 176.46, 176.33, 171.49, 156.69, 145.2, 145.48, 153.91, 193.88, 171.4, 148.65, 0]
line [9.25, 86.07, 123.66, 136.46, 118.98, 167.85, 178.58, 187.57, 184.02, 149.85, 176.49, 172.27, 159.4, 143.26, 144.72, 145.08, 171.2, 137.32, 139.23, 135.49, 135.54, 135.59, 153.28, 152.7, 156.04, 267.69, 255.36, 204.74, 222.79, 172.74, 173.05, 167.93, 153, 141.51, 141.79, 150.28, 190.12, 167.55, 144.81, 0]
HEADxychart-beta
title "HEAD CPU"
x-axis "Elapsed seconds" [1.047, 1.548, 2.55, 4.055, 5.056, 6.559, 7.561, 9.063, 10.064, 11.566, 12.567, 14.07, 15.071, 16.573, 17.574, 19.075, 20.075, 21.577, 23.078, 24.079, 25.581, 26.082, 26.583, 28.085, 29.086, 30.588, 31.59, 33.091, 34.092, 35.595, 36.596, 38.099, 39.101, 40.603, 41.605, 42.106, 43.107, 44.109]
y-axis "CPU percent" 0 --> 500
line [5.99, 91.9, 3.99, 121.73, 107.79, 167.67, 137.79, 163.69, 90.04, 133.84, 139.83, 103.85, 129.8, 123.9, 117.92, 89.88, 55.97, 80.01, 72, 135.72, 103.82, 103.82, 105.84, 129.88, 155.83, 59.89, 151.8, 135.95, 102, 123.64, 5.99, 135.82, 125.93, 19.99, 67.89, 197.59, 75.89, 119.78]
xychart-beta
title "HEAD memory: RSS then PSS"
x-axis "Elapsed seconds" [0.048, 1.047, 1.548, 2.55, 4.055, 5.056, 6.559, 7.561, 9.063, 10.064, 11.566, 12.567, 14.07, 15.071, 16.573, 17.574, 19.075, 20.075, 21.577, 23.078, 24.079, 25.581, 26.082, 26.583, 28.085, 29.086, 30.588, 31.59, 33.091, 34.092, 35.595, 36.596, 38.099, 39.101, 40.603, 41.605, 42.106, 43.107, 44.109, 45.383]
y-axis "Memory MiB" 0 --> 500
line [12.66, 64.85, 95.7, 99.07, 132.3, 131.19, 148.14, 179.72, 185.73, 173.8, 168.11, 163.17, 173.75, 170.05, 170.26, 155.11, 161.56, 152.58, 157.69, 145.99, 162.61, 218.98, 279.41, 210.32, 208.27, 221.2, 166.14, 182.14, 182.82, 151.86, 163.62, 152.45, 203.48, 218.75, 176.74, 178.96, 161.05, 159.33, 182.15, 0]
line [9.21, 61.1, 91.96, 95.28, 128.5, 127.46, 144.38, 175.95, 181.85, 170.48, 164.28, 159.25, 169.88, 166.87, 166.37, 151.21, 157.67, 149.06, 153.89, 142.13, 158.76, 215.14, 277, 205.92, 204.33, 217.25, 162.29, 178.21, 178.77, 147.96, 159.71, 148.61, 200.24, 212.76, 172.95, 175.13, 156.74, 155.54, 178.38, 0]
Deterministic fixture · required contractThe fixture exercises 15 routes: 8 are expected to emit rows and 7 intentionally exercise empty, loading, or timeout behavior.
Full HTML, JSON, CSV, logs, and page snapshots: workflow run and full The public-web A/B is informational. The exact HEAD fixture contract runs as a separate required CI check; timing and public-site content deltas remain non-blocking. |
CI Regression ReportSource CI run · source state at render:
Release regression — ✅ HEAD/base failures 0/0; raw binary +0.000072%Package and image size
Startup latency and PSS
Concurrency matrix
Frontend differential — ✅ 1,020/1,020 cases matched; 0 issues
Agent episodes · Moli vs Chromium — ✅ 8/8 Moli episodes passed; 0 failures
Runtime and CDP session contracts — ✅ 26 contract cases; 0 failures
CDP smoke — ✅ 52/52 groups passed; 621 scenariosWorkers: 4 · cumulative group time: 130.35 s · failed groups: 0
WebMainBench · 545 pages — ✅ 545/545 completed; 0 unexpected failures
Frozen HTML · Linux · Diagnostics: All artifact fields are parsed by the trusted default-branch renderer; missing or invalid inputs remain visible as unavailable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moli currently classifies PDF responses as raw downloads, but treats the standard DOCX MIME type as a renderable document.
fetch --dump markdowncan therefore exit successfully while writing ZIP bytes beginning withPKinstead of document text.This change centralizes the existing Office MIME set and uses it for both raw main-document handling and ORB classification. OOXML, common legacy Office, and macro-enabled Office responses now follow the same raw-download contract as PDF and ZIP. A Markdown request fails clearly with empty stdout; automatic/raw and JSON transfer behavior remain available. HTML and
text/plaincontinue through the normal document renderer.The behavior tests cover the public CLI outcome for DOCX and negative controls for HTML and plain text. MIME tests cover representative Word, Excel, and PowerPoint types. This does not add PDF/DOCX parsing, benchmark-specific routing, or postprocessing.
This PR targets
maindirectly and is independent of #919 and the #1334–#1432 product stack. Format, Clippy, and the test suite are delegated to repository CI; no local test suite was run.