Skip to content

fix(trusted-types): avoid duplicate reports for transformed trusted scripts - #1457

Merged
ldm0 merged 1 commit into
mainfrom
wpt/20261013-trusted-script-compilation-reports
Oct 16, 2026
Merged

ldm0 merged 1 commit into
mainfrom
wpt/20261013-trusted-script-compilation-reports

Conversation

@ldm0

@ldm0 ldm0 commented Oct 12, 2026

Copy link
Copy Markdown
Member

A default policy can produce TrustedScript whose source is unsuitable for eval or Function compilation. Rejecting that transformed source currently also emits a sink-mismatch report, even though the policy supplied the required trusted type.

Keep the compilation EvalError while suppressing the extra Trusted Types violation. Exercise eval and Function with transforming default policies and verify queued violation delivery remains empty.

Validation on this branch, based directly on main cac20d15b838:

  • cargo fmt --all
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo nextest run --no-fail-fast --test-threads 32 --retries 0: 20064 passed, 17 skipped.

Extracted from the existing WPT work branch; no unmerged PR prerequisites.

@github-actions

Copy link
Copy Markdown

Sequential Navigation Soak A/B

⚠️ HEAD did not produce a complete resilience/memory observation: HEAD attempted is not 200; HEAD resource_sample_count is not 200; HEAD rss_observed_samples is not 200; HEAD pss_observed_samples is not 200; HEAD fd_observed_samples is not 200; HEAD recovery_failures is not 0.

One browser process, one target, and one CDP session navigate CSDN → SegmentFault → Huaban → example.com repeatedly. This run issued 200 Page.navigate commands per binary.

Common ancestor cac20d15b8 → HEAD aded8ae59c; benchmark order: base-first; workflow: failure.

Session resilience

Metric Base HEAD
Attempted / planned 200 / 200 20 / 200
Direct observable pass 195 / 200 17 / 20
Failures / recovered 5 / 5 3 / 2
Recovery failures 0 1
Lifecycle order violations 0 0
Network order violations 0 0
Wall time 849.4 s 138.2 s

A public-page failure is reported separately from an unrecoverable session. The soak requires all navigation attempts, zero failed recovery, zero lifecycle/network ordering violations, and complete resource evidence.

Process-tree memory

Metric Base HEAD Δ
Boundary samples 200 20 -180
Boundary RSS samples 200 20 -180
Boundary PSS samples 200 20 -180
Periodic peak RSS 291.5 MiB 292.1 MiB +0.6 MiB
Periodic peak PSS 288.3 MiB 289.6 MiB +1.3 MiB
RSS · first 10 avg 173.1 MiB 179.6 MiB +6.5 MiB
RSS · last 10 avg 182.6 MiB 168.6 MiB -14.0 MiB
RSS · last − first window +9.5 MiB -11.0 MiB -20.6 MiB
RSS · warm slope / 100 nav +3.7 MiB -202.3 MiB -206.0 MiB
PSS · first 10 avg 170.1 MiB 177.1 MiB +7.0 MiB
PSS · last 10 avg 179.5 MiB 166.3 MiB -13.1 MiB
PSS · last − first window +9.4 MiB -10.8 MiB -20.2 MiB
PSS · warm slope / 100 nav +4.0 MiB -201.2 MiB -205.2 MiB
Peak file descriptors 57 58 1
Peak threads 31 29 -2

HEAD memory by 50-navigation quarter

HEAD range Avg RSS Final RSS Peak RSS Avg PSS Final PSS Peak FD
1–5 178.9 MiB 206.8 MiB 206.8 MiB 176.6 MiB 205.5 MiB 52
6–10 180.3 MiB 179.9 MiB 206.8 MiB 177.6 MiB 177.6 MiB 48
11–15 177.7 MiB 185.0 MiB 203.2 MiB 175.1 MiB 182.7 MiB 56
16–20 159.5 MiB 134.7 MiB 199.0 MiB 157.5 MiB 132.5 MiB 48

Raw reports and per-navigation boundary samples: workflow run and full sequential-navigation-soak-results artifact.

Public-site timing and memory are observational. Use the A/B deltas and trend shape as evidence, not as a deterministic performance threshold.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Spider Bench A/B

✅ All benchmark browser service runs completed; results are informational.

Public HEAD: 189 / 240 rows; 39 / 48 sites produced rows; 9 unexpected empty sites.

✅ Deterministic fixture contract is clean.

Common ancestor cac20d15b838 → HEAD aded8ae59c26; benchmark order: base-first; workflow: success.

Public 48-site run · informational

Metric Base HEAD Δ
Run status success success —
Extracted rows / contract 189 / 240 189 / 240 0 (0.00%)
Contract fill 78.75% 78.75% 0.00 pp (0.00%)
Sites with rows 39 / 48 39 / 48 0 (0.00%)
Sites meeting row contract 37 / 48 37 / 48 0 (0.00%)
Unexpected empty sites 9 9 0 (0.00%)
Partial-row sites 2 2 0 (0.00%)
Site outcomes extracted: 37; HTTP error + rows: 2; empty: 6; HTTP error + empty: 1; snapshot error + empty: 2 extracted: 38; HTTP error + rows: 1; empty: 6; HTTP error + empty: 1; snapshot error + empty: 2 —
Observed duration 47.89 s 47.01 s -0.88 s (-1.84%)
Estimated CPU 52.84 s 46.20 s -6.64 s (-12.57%)
Peak PSS 288.76 MiB 290.93 MiB +2.17 MiB (+0.75%)
Peak RSS 292.48 MiB 294.08 MiB +1.61 MiB (+0.55%)
Peak threads 26 26 0 (0.00%)
Mismatched sites 0 0 0
Timeout with items 0 0 0
Category rows Base HEAD Δ
news 35 / 40 35 / 40 0
stocks 20 / 40 20 / 40 0
tech 35 / 40 35 / 40 0
sports 32 / 40 32 / 40 0
games 37 / 40 37 / 40 0
life 30 / 40 30 / 40 0

Public-site content, timing, and memory are noisy. This single A/B run reports evidence only; site outcome counts explain missing rows without treating them as a deterministic regression.

CPU and memory timelines

These are bounded 40-point views of the same complete process-tree samples used by the HTML report. CPU uses 100% per occupied logical core; memory lines are RSS first and PSS second when complete PSS samples are available.

Base

xychart-beta
    title "Base CPU"
    x-axis "Elapsed seconds" [1.535, 2.537, 4.04, 5.541, 6.543, 7.543, 8.044, 9.546, 10.546, 12.048, 13.551, 14.552, 16.053, 17.555, 18.556, 20.059, 21.561, 22.563, 24.064, 25.567, 26.568, 27.569, 28.07, 29.572, 30.573, 32.076, 33.578, 34.579, 36.081, 37.583, 38.584, 40.086, 41.087, 41.588, 42.59, 44.092, 45.593, 46.595]
    y-axis "CPU percent" 0 --> 500
    line [32, 121.79, 113.79, 152.09, 211.67, 228.06, 111.84, 174, 177.76, 95.87, 165.7, 139.98, 69.94, 27.97, 123.96, 79.79, 75.83, 65.83, 94, 123.85, 133.86, 107.85, 111.8, 133.61, 119.84, 121.85, 149.8, 105.87, 119.66, 99.89, 141.88, 87.86, 3.99, 7.98, 69.82, 106.02, 77.9, 103.79]
Loading
xychart-beta
    title "Base memory: RSS then PSS"
    x-axis "Elapsed seconds" [0.035, 1.535, 2.537, 4.04, 5.541, 6.543, 7.543, 8.044, 9.546, 10.546, 12.048, 13.551, 14.552, 16.053, 17.555, 18.556, 20.059, 21.561, 22.563, 24.064, 25.567, 26.568, 27.569, 28.07, 29.572, 30.573, 32.076, 33.578, 34.579, 36.081, 37.583, 38.584, 40.086, 41.087, 41.588, 42.59, 44.092, 45.593, 46.595, 47.887]
    y-axis "Memory MiB" 0 --> 500
    line [12.49, 88.52, 115.13, 147.4, 150.66, 175.02, 207.33, 215.3, 231.36, 183.35, 165.03, 204.3, 178.7, 174.94, 194.95, 168.67, 156.23, 165.48, 153.42, 178, 165.87, 181.63, 292.48, 219.93, 212.54, 159.61, 198.74, 173.57, 154.09, 160.94, 158.33, 218.48, 192.71, 178.5, 165.95, 179.02, 190.8, 161.61, 183.08, 0]
    line [9.07, 84.76, 111.36, 143.62, 147.05, 171.87, 203.62, 211.52, 227.67, 178.02, 161.21, 200.04, 174.86, 171.1, 191.11, 164.83, 152.39, 161.64, 148.99, 174.16, 162.06, 177.79, 288.76, 216.26, 208.76, 155.81, 195.03, 170.05, 150.75, 157.31, 154.6, 214.9, 188.98, 174.77, 162.21, 175.35, 187.2, 158.43, 179.36, 0]
Loading

HEAD

xychart-beta
    title "HEAD CPU"
    x-axis "Elapsed seconds" [1.037, 1.538, 2.539, 4.042, 5.044, 6.545, 8.047, 9.049, 10.552, 12.054, 13.055, 14.556, 15.556, 16.558, 17.059, 18.56, 19.562, 21.063, 22.065, 23.567, 25.068, 26.069, 27.57, 28.572, 30.075, 31.577, 32.577, 34.08, 35.582, 36.583, 38.085, 39.087, 40.589, 42.09, 43.092, 44.595, 45.597, 46.599]
    y-axis "CPU percent" 0 --> 200
    line [2, 5.98, 115.82, 131.77, 135.77, 153.92, 135.78, 155.64, 129.64, 91.9, 133.81, 8, 2, 0, 3.99, 0, 59.94, 155.91, 19.98, 129.86, 102.04, 127.89, 102, 109.77, 127.78, 131.83, 166.09, 117.69, 77.93, 55.92, 147.81, 141.91, 73.99, 93.86, 119.78, 29.94, 137.78, 179.88]
Loading
xychart-beta
    title "HEAD memory: RSS then PSS"
    x-axis "Elapsed seconds" [0.036, 1.037, 1.538, 2.539, 4.042, 5.044, 6.545, 8.047, 9.049, 10.552, 12.054, 13.055, 14.556, 15.556, 16.558, 17.059, 18.56, 19.562, 21.063, 22.065, 23.567, 25.068, 26.069, 27.57, 28.572, 30.075, 31.577, 32.577, 34.08, 35.582, 36.583, 38.085, 39.087, 40.589, 42.09, 43.092, 44.595, 45.597, 46.599, 47.007]
    y-axis "Memory MiB" 0 --> 500
    line [12.45, 61.95, 63.77, 114.28, 133.32, 145.11, 163.99, 186.5, 176.68, 185.69, 176.4, 170.29, 162.91, 151.15, 148.54, 149.3, 150.36, 158.99, 171.89, 147.5, 177.05, 148.78, 162.45, 294.08, 203.41, 243.15, 166.61, 186.76, 171.08, 151.8, 156.26, 215.6, 243.26, 196.48, 180.2, 204.09, 160.29, 177.57, 200.79, 0]
    line [9.14, 58.18, 60, 110.58, 129.65, 141.87, 160.22, 182.72, 172.61, 181.11, 172.75, 166.83, 159.23, 147.63, 144.58, 145.78, 146.57, 155.47, 169.17, 143.7, 174.75, 145.01, 158.51, 290.93, 199.82, 239.51, 162.94, 182.54, 167.61, 148.26, 152.62, 211.86, 239.34, 192.84, 176.61, 200.73, 156.69, 173.96, 197.16, 0]
Loading

Deterministic fixture · required contract

The fixture exercises 15 routes: 8 are expected to emit rows and 7 intentionally exercise empty, loading, or timeout behavior.

Metric Base HEAD Δ
Run status success success —
Extracted rows / contract 40 / 40 40 / 40 0 (0.00%)
Contract fill 100.00% 100.00% 0.00 pp (0.00%)
Sites with rows 8 / 15 8 / 15 0 (0.00%)
Sites meeting row contract 15 / 15 15 / 15 0 (0.00%)
Unexpected empty sites 0 0 0
Partial-row sites 0 0 0
Site outcomes extracted: 7; HTTP error + rows: 1; empty: 3; timeout + empty: 4 extracted: 7; HTTP error + rows: 1; empty: 3; timeout + empty: 4 —
Observed duration 19.86 s 19.86 s +0.00 s (+0.02%)
Estimated CPU 0.41 s 0.43 s +0.02 s (+5.10%)
Peak PSS 66.11 MiB 65.97 MiB -0.14 MiB (-0.21%)
Peak RSS 69.69 MiB 69.74 MiB +0.05 MiB (+0.07%)
Peak threads 18 18 0 (0.00%)
Mismatched sites 0 0 0
Timeout with items 0 0 0

Full HTML, JSON, CSV, logs, and page snapshots: workflow run and full spider-bench-results artifact.

The public-web A/B is informational. The exact HEAD fixture contract runs as a separate required CI check; timing and public-site content deltas remain non-blocking.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

CI Regression Report

Source CI run · source state at render: in_progress · artifacts: 6/6

Check Status Signal
Release regression ✅ HEAD/base failures 0/0; raw binary 0.00%
Frontend differential ❌ 1,019/1,020 cases matched; 1 issues
Agent episodes ✅ 8/8 Moli episodes passed; 0 failures
Runtime/CDP contracts ✅ 26 contract cases; 0 failures
CDP smoke ✅ 52/52 groups passed; 621 scenarios
WebMainBench ✅ 545/545 completed; 0 unexpected failures
Release regression — ✅ HEAD/base failures 0/0; raw binary 0.00%

Package and image size

Metric Base HEAD Delta Delta %
Raw binary 150.47 MiB 150.47 MiB 0 B 0.00%
Stripped binary 103.95 MiB 103.95 MiB 0 B 0.00%
gzip binary 51.74 MiB 51.74 MiB −382 B −0.000704%
Rootfs 157.37 MiB 157.37 MiB 0 B 0.00%
gzip rootfs 60.69 MiB 60.68 MiB −1.43 KiB −0.002307%

Startup latency and PSS

Case Base p50 HEAD p50 Delta Base PSS HEAD PSS Delta
Serve ready 27.61 ms 27.42 ms −0.19 ms 4.91 MiB 4.02 MiB −914.50 KiB
CDP first page 51.44 ms 50.87 ms −0.57 ms 5.22 MiB 3.97 MiB −1.25 MiB
CDP warm page 12.52 ms 12.20 ms −0.31 ms 49.76 MiB 49.41 MiB −358.50 KiB
CLI about:blank 16.17 ms 15.91 ms −0.26 ms 4.29 MiB 2.78 MiB −1.51 MiB
CLI local JS 18.43 ms 19.44 ms +1.01 ms 3.93 MiB 2.68 MiB −1.25 MiB

Concurrency matrix

Concurrency Base p50 HEAD p50 Delta Base PSS HEAD PSS Delta HEAD failures Unstable B/H
1 18.52 ms 18.51 ms −0.01 ms 644.00 KiB 589.00 KiB −55.00 KiB 0 0/0
5 20.53 ms 21.25 ms +0.72 ms 13.72 MiB 22.08 MiB +8.36 MiB 0 0/0
10 21.11 ms 22.22 ms +1.11 ms 26.95 MiB 12.99 MiB −13.96 MiB 0 0/0
25 21.35 ms 20.87 ms −0.48 ms 13.01 MiB 12.54 MiB −491.00 KiB 0 0/0
100 20.60 ms 21.54 ms +0.93 ms 13.06 MiB 27.50 MiB +14.44 MiB 0 0/0
Frontend differential — ❌ 1,019/1,020 cases matched; 1 issues
Match DOM mismatch Diagnostic mismatch Moli error Reference error Infrastructure error Mismatched frames Duration
0 0 0 0 1 0 0 3m 51.08s

First failing cases

  • angular/browsing-context-boundaries/sandboxed-opaque-origin-frame — reference_error · Chromium error fixture did not become ready: {'id': 'angular/browsing-context-boundaries/sandboxed-opaque-origin-frame', 'framework': 'angular', 'phase': 'error', 'checkpoints
Agent episodes · Moli vs Chromium — ✅ 8/8 Moli episodes passed; 0 failures
Fast contract Episodes Passed Assertions Ready p50 Episode p50
Moli 8 8 47/47 3.49 ms 27.41 ms
Chromium 8 8 47/47 241.28 ms 91.78 ms
Operation p50 Chromium Moli Delta Delta %
navigate 44.50 ms 6.39 ms −38.11 ms −85.64%
observe 1.01 ms 1.20 ms +0.19 ms +18.54%
fill 3.33 ms 3.59 ms +0.26 ms +7.93%
click 5.47 ms 4.42 ms −1.05 ms −19.23%
Idle-resource episode Peak RSS Peak PSS Average CPU Peak CPU Peak processes Sampler
Moli 65.52 MiB 63.82 MiB 0.79% 10.01% 1 ✅
Chromium 1286.20 MiB 409.33 MiB 2.13% 97.84% 13 ⚠️ PSS partial
Runtime and CDP session contracts — ✅ 26 contract cases; 0 failures
Suite Cases Failures Median case p50 Median case p95 Median peak PSS p50
Synthetic fetch 13 0 29.36 ms 32.86 ms 789.00 KiB
Long-lived CDP session 13 0 18.28 ms 18.92 ms —
CDP smoke — ✅ 52/52 groups passed; 621 scenarios

Workers: 4 · cumulative group time: 189.74 s · failed groups: 0

Slowest group Scenarios Duration Status
scrollbar-visibility 22 27.62 s ✅
target-lifecycle 24 15.55 s ✅
dom-input 27 13.27 s ✅
chromium-cdp 56 11.20 s ✅
multi-page 45 10.45 s ✅
WebMainBench · 545 pages — ✅ 545/545 completed; 0 unexpected failures
Completed Successful Expected DNS failure Unexpected failures Panics Crashes Timeouts Empty output
545/545 544 1 0 0 0 0 0

Frozen HTML · Linux · --wait done · 45 seconds per page · no retries. Content quality is evaluated separately.

Diagnostics: webmainbench-results — every page's Markdown, stderr, and exit status. Source run and artifacts

All artifact fields are parsed by the trusted default-branch renderer; missing or invalid inputs remain visible as unavailable.

@ldm0
ldm0 merged commit 9279ef4 into main Oct 16, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant