Skip to content

fix(navigation): cancel loading while preserving committed content - #738

Merged
lanyue-llk merged 1 commit into
mainfrom
codex/pr640-stop-loading-final
Sep 22, 2026
Merged

lanyue-llk merged 1 commit into
mainfrom
codex/pr640-stop-loading-final

Conversation

@lanyue-llk

@lanyue-llk lanyue-llk commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

停止加载时,取消网络、解析与导航状态需要协调;清空已经提交的页面会丢失用户正在查看的内容,迟到回调则可能污染新导航。

Reviewer 图解入口

artifact-site:七个 PR 的职责、依赖、原 11 类与 35 题证据。建议审查顺序:734 → 735 → 736 → 737 → 738 → 739 → 740;实际依赖以指南中的有向图为准。

图解与验收证据见站点报告;精确 HEAD 与完整成功、失败记录见下文。

当前 HEAD e9c3b70ceb73a9e1b36b44bbb9281ecbf3c51c17 已基于 main@a54ba82a7ac6462429d2f60cd0dbd0d67c589e84 或其直接父 PR 重放;b43a213dc6b6 的真实任务/专项证据和新提交的补丁等价边界分别核对。旧测试结果只对应归档二进制;当前 HEAD 由本 PR 的 CI 单独验证。

修复机制

取消动作作用于明确的导航/传输所有者。区分 provisional 与已提交文档,保留已解析内容,收拢 load gate 和任务结束处理,让旧任务完成不能改变新文档。

机制示意与验收证据见 artifact-site 审查报告;图片仅用于解释机制,不代表本 PR 的验收结果。

对应验收

本分区采用独立功能契约验收。

回归覆盖:提交前/后取消、慢响应分块、取消幂等性、已解析内容保留、事件次数、迟到完成及立即发起的新导航。

停止加载通过独立 HTTP 取消场景验收,不认领 35 题中的其他功能。提交前/后取消和 held socket 释放的场景保留原断言,由当前 HEAD 的门禁重新验证。

当前版本 标识与验证范围
HEAD e9c3b70ceb73a9e1b36b44bbb9281ecbf3c51c17
直接基线 746e376f0179988d0aa6250cb055aee2baaebb4f
main 基线 a54ba82a7ac6462429d2f60cd0dbd0d67c589e84
当前版本门禁 以该 HEAD 的 Format、Clippy、Nextest 结果为准;历史结果不替代当前门禁

范围与依赖

以工程 PR #734 为直接基线;diff 展示本分区修改。

本 PR 替代 730,基于更新后的 main;旧 PR 保留讨论与 review 历史。原始 #640 也保留作为拆分来源。

整组功能范围为历史 1.1.9 的 34 个失败任务加 1.1.8 已失败的 386,共 35 题:布局 27、输入 4、网络 3、文本 1。历史 67 是传输超时,保留证据但不归因本组功能修复。逐 case 历史及当前归属;历史 11 类分组。历史 main@de109 的 90 题基线 为 55/90,其运行顺序与后续子集不同,结果差异本身不作为独立因果证明。

7 个 PR 的依赖及逐题验收索引、PR 与提交账号核验。

35 题最终逐项来源总表;布局是 v3 的 26 题加 v4 单独 547,不是单轮 27/27。

@github-actions

Copy link
Copy Markdown

Sequential Navigation Soak A/B

⚠️ Benchmark infrastructure failed before a comparison could be produced.

Workflow: timed_out. Inspect the workflow run for the failing build, harness, or artifact step.

No navigation resilience or memory conclusion is available for this run.

@github-actions

Copy link
Copy Markdown

Spider Bench A/B

⚠️ Spider Bench infrastructure failed before a comparison could be produced.

Workflow: timed_out. Inspect the workflow run for the failing build, harness, or artifact step.

No benchmark result or performance conclusion is available for this run.

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

CI Regression Report

Source CI run · source state at render: in_progress · artifacts: 5/5

Check Status Signal
Release regression ✅ HEAD/base failures 0/0; raw binary +0.003227%
Frontend differential ✅ 1,020/1,020 cases matched; 0 issues
Agent episodes ✅ 8/8 Moli episodes passed; 0 failures
Runtime/CDP contracts ✅ 26 contract cases; 0 failures
CDP smoke ✅ 48/48 groups passed; 535 scenarios
Release regression — ✅ HEAD/base failures 0/0; raw binary +0.003227%

Package and image size

Metric Base HEAD Delta Delta %
Raw binary 146.36 MiB 146.36 MiB +4.84 KiB +0.003227%
Stripped binary 100.45 MiB 100.45 MiB +4.00 KiB +0.003889%
gzip binary 50.09 MiB 50.09 MiB +3.85 KiB +0.007498%
Rootfs 153.26 MiB 153.26 MiB 0 B 0.00%
gzip rootfs 58.86 MiB 58.87 MiB +10.40 KiB +0.017257%

Startup latency and PSS

Case Base p50 HEAD p50 Delta Base PSS HEAD PSS Delta
Serve ready 5.08 ms 27.24 ms +22.16 ms 9.24 MiB 5.25 MiB −3.99 MiB
CDP first page 64.68 ms 49.69 ms −15.00 ms 4.73 MiB 3.96 MiB −787.00 KiB
CDP warm page 14.55 ms 12.01 ms −2.54 ms 48.58 MiB 49.74 MiB +1.16 MiB
CLI about:blank 28.46 ms 14.20 ms −14.26 ms 5.85 MiB 2.80 MiB −3.05 MiB
CLI local JS 18.22 ms 19.31 ms +1.09 ms 4.36 MiB 3.35 MiB −1.02 MiB

Concurrency matrix

Concurrency Base p50 HEAD p50 Delta Base PSS HEAD PSS Delta HEAD failures Unstable B/H
1 18.27 ms 17.82 ms −0.45 ms 641.00 KiB 717.00 KiB +76.00 KiB 0 0/0
5 29.06 ms 23.38 ms −5.68 ms 10.29 MiB 14.20 MiB +3.91 MiB 0 0/0
10 25.50 ms 21.88 ms −3.62 ms 11.52 MiB 16.58 MiB +5.06 MiB 0 0/0
25 26.13 ms 21.51 ms −4.62 ms 11.70 MiB 20.16 MiB +8.46 MiB 0 0/0
100 26.49 ms 20.60 ms −5.89 ms 12.15 MiB 27.26 MiB +15.11 MiB 0 0/0
Frontend differential — ✅ 1,020/1,020 cases matched; 0 issues
Match DOM mismatch Diagnostic mismatch Moli error Reference error Infrastructure error Mismatched frames Duration
1,020 0 0 0 0 0 0 7m 37.90s
Agent episodes · Moli vs Chromium — ✅ 8/8 Moli episodes passed; 0 failures
Fast contract Episodes Passed Assertions Ready p50 Episode p50
Moli 8 8 47/47 3.48 ms 24.72 ms
Chromium 8 8 47/47 244.63 ms 82.76 ms
Operation p50 Chromium Moli Delta Delta %
navigate 41.11 ms 6.78 ms −34.33 ms −83.51%
observe 1.75 ms 0.86 ms −0.90 ms −51.22%
fill 3.47 ms 3.11 ms −0.36 ms −10.49%
click 4.67 ms 3.51 ms −1.16 ms −24.90%
Idle-resource episode Peak RSS Peak PSS Average CPU Peak CPU Peak processes Sampler
Moli 64.40 MiB 62.58 MiB 0.70% 10.00% 1 ✅
Chromium 1291.76 MiB 421.98 MiB 2.34% 88.09% 13 ⚠️ PSS partial
Runtime and CDP session contracts — ✅ 26 contract cases; 0 failures
Suite Cases Failures Median case p50 Median case p95 Median peak PSS p50
Synthetic fetch 13 0 17.28 ms 18.08 ms 643.00 KiB
Long-lived CDP session 13 0 19.70 ms 20.12 ms —
CDP smoke — ✅ 48/48 groups passed; 535 scenarios

Workers: 4 · cumulative group time: 146.54 s · failed groups: 0

Slowest group Scenarios Duration Status
target-lifecycle 24 16.03 s ✅
multi-page 45 11.02 s ✅
chromium-cdp 56 10.80 s ✅
dom-input 27 10.66 s ✅
layout-screenshot 5 7.53 s ✅

All artifact fields are parsed by the trusted default-branch renderer; missing or invalid inputs remain visible as unavailable.

@lanyue-llk
lanyue-llk force-pushed the codex/pr640-reliability-final branch from 2e9c285 to 746e376 Compare September 22, 2026 09:49
@lanyue-llk
lanyue-llk force-pushed the codex/pr640-stop-loading-final branch from b43a213 to e9c3b70 Compare September 22, 2026 09:56
@lanyue-llk
lanyue-llk force-pushed the codex/pr640-stop-loading-final branch from e9c3b70 to 5f73c34 Compare September 22, 2026 11:46
@lanyue-llk
lanyue-llk changed the base branch from codex/pr640-reliability-final to main September 22, 2026 11:46
@lanyue-llk
lanyue-llk merged commit 011e226 into main Sep 22, 2026
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant