Skip to content

fix(input): preserve activation and navigation boundaries - #775

Merged
ldm0 merged 4 commits into
mainfrom
input-fix-llk
Sep 23, 2026
Merged

fix(input): preserve activation and navigation boundaries#775
ldm0 merged 4 commits into
mainfrom
input-fix-llk

Conversation

@ldm0

@ldm0 ldm0 commented Sep 23, 2026

Copy link
Copy Markdown
Member

No description provided.

@ldm0

ldm0 commented Sep 23, 2026

Copy link
Copy Markdown
Member Author

Supersedes #757

@github-actions

github-actions Bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Spider Bench A/B

✅ All benchmark browser service runs completed; results are informational.

Public HEAD: 179 / 240 rows; 37 / 48 sites produced rows; 11 unexpected empty sites.

✅ Deterministic fixture contract is clean.

Common ancestor 7540d64247ee → HEAD 42de4ab088dd; benchmark order: base-first; workflow: success.

Public 48-site run · informational

Metric Base HEAD Δ
Run status success success —
Extracted rows / contract 179 / 240 179 / 240 0 (0.00%)
Contract fill 74.58% 74.58% 0.00 pp (0.00%)
Sites with rows 37 / 48 37 / 48 0 (0.00%)
Sites meeting row contract 35 / 48 35 / 48 0 (0.00%)
Unexpected empty sites 11 11 0 (0.00%)
Partial-row sites 2 2 0 (0.00%)
Site outcomes extracted: 35; HTTP error + rows: 2; empty: 7; HTTP error + empty: 2; snapshot error + empty: 2 extracted: 36; HTTP error + rows: 1; empty: 7; HTTP error + empty: 1; navigation error + empty: 1; snapshot error + empty: 2 —
Observed duration 83.18 s 91.48 s +8.31 s (+9.99%)
Estimated CPU 57.09 s 59.74 s +2.65 s (+4.64%)
Peak PSS 253.46 MiB 249.97 MiB -3.49 MiB (-1.38%)
Peak RSS 257.07 MiB 253.44 MiB -3.63 MiB (-1.41%)
Peak threads 27 26 -1 (-3.70%)
Mismatched sites 0 0 0
Timeout with items 0 0 0
Category rows Base HEAD Δ
news 35 / 40 35 / 40 0
stocks 20 / 40 20 / 40 0
tech 35 / 40 35 / 40 0
sports 27 / 40 27 / 40 0
games 32 / 40 32 / 40 0
life 30 / 40 30 / 40 0

Public-site content, timing, and memory are noisy. This single A/B run reports evidence only; site outcome counts explain missing rows without treating them as a deterministic regression.

CPU and memory timelines

These are bounded 40-point views of the same complete process-tree samples used by the HTML report. CPU uses 100% per occupied logical core; memory lines are RSS first and PSS second when complete PSS samples are available.

Base

xychart-beta
    title "Base CPU"
    x-axis "Elapsed seconds" [2.037, 2.538, 4.542, 7.048, 9.552, 11.554, 14.057, 16.06, 18.061, 18.561, 21.067, 23.069, 25.572, 28.074, 30.077, 32.581, 35.085, 37.087, 39.59, 42.094, 44.096, 46.598, 48.601, 51.104, 53.607, 55.609, 58.113, 60.616, 62.618, 65.12, 67.622, 69.625, 72.129, 74.132, 76.633, 79.136, 81.137, 82.638]
    y-axis "CPU percent" 0 --> 500
    line [63.96, 111.91, 141.71, 133.75, 87.79, 143.82, 81.97, 93.92, 0, 23.98, 65.85, 4, 93.8, 105.8, 97.92, 102.03, 97.7, 117.91, 67.97, 9.98, 125.95, 31.94, 47.87, 27.98, 0, 0, 21.98, 0, 0, 21.98, 0, 1.99, 95.88, 11.99, 107.9, 97.95, 98.07, 199.97]
Loading 
xychart-beta
    title "Base memory: RSS then PSS"
    x-axis "Elapsed seconds" [0.036, 2.037, 2.538, 4.542, 7.048, 9.552, 11.554, 14.057, 16.06, 18.061, 18.561, 21.067, 23.069, 25.572, 28.074, 30.077, 32.581, 35.085, 37.087, 39.59, 42.094, 44.096, 46.598, 48.601, 51.104, 53.607, 55.609, 58.113, 60.616, 62.618, 65.12, 67.622, 69.625, 72.129, 74.132, 76.633, 79.136, 81.137, 82.638, 83.176]
    y-axis "Memory MiB" 0 --> 500
    line [12.17, 110.09, 115.47, 122.81, 164.91, 158.96, 159.44, 164.11, 178.38, 164.03, 141.09, 155.73, 151.43, 150.91, 154.11, 257.07, 217.09, 162.76, 167.71, 143.96, 148.2, 179.61, 239.41, 251.78, 244.97, 243.75, 243.77, 243.72, 243.75, 243.75, 242.68, 242.7, 242.55, 159.76, 143.78, 191.64, 152.34, 146.13, 175.94, 0]
    line [9.1, 106.8, 112.02, 119.34, 162.85, 155.46, 155.86, 161.14, 174.38, 160.42, 137.44, 152.05, 147.72, 147.28, 150.4, 253.46, 213.47, 159.12, 164.22, 140.41, 144.66, 176.07, 235.91, 248.31, 241.5, 240.28, 240.3, 240.23, 240.26, 240.28, 239.21, 239.23, 239.08, 156.29, 140.31, 188.22, 148.87, 142.77, 172.47, 0]
Loading

HEAD

xychart-beta
    title "HEAD CPU"
    x-axis "Elapsed seconds" [2.538, 4.539, 5.04, 7.544, 10.048, 12.551, 15.555, 18.059, 20.561, 23.064, 25.568, 28.071, 30.574, 33.075, 35.578, 37.08, 38.082, 40.586, 43.09, 44.091, 46.093, 48.596, 51.1, 53.604, 56.107, 58.609, 61.112, 63.615, 66.118, 68.621, 71.124, 73.627, 76.631, 79.136, 81.637, 84.14, 86.643, 89.146]
    y-axis "CPU percent" 0 --> 200
    line [0, 117.83, 111.84, 129.8, 87.8, 103.93, 133.9, 37.96, 2, 5.99, 0, 109.94, 15.96, 105.96, 81.79, 101.7, 137.66, 137.88, 131.84, 187.84, 67.96, 6, 141.68, 2, 21.98, 2, 23.98, 0, 21.98, 0, 23.98, 2, 0, 21.94, 11.99, 133.81, 109.92, 111.93]
Loading 
xychart-beta
    title "HEAD memory: RSS then PSS"
    x-axis "Elapsed seconds" [0.035, 2.538, 4.539, 5.04, 7.544, 10.048, 12.551, 15.555, 18.059, 20.561, 23.064, 25.568, 28.071, 30.574, 33.075, 35.578, 37.08, 38.082, 40.586, 43.09, 44.091, 46.093, 48.596, 51.1, 53.604, 56.107, 58.609, 61.112, 63.615, 66.118, 68.621, 71.124, 73.627, 76.631, 79.136, 81.637, 84.14, 86.643, 89.146, 91.482]
    y-axis "Memory MiB" 0 --> 500
    line [12.75, 103.64, 136.07, 133.43, 156.25, 165.49, 189.69, 181.64, 160.86, 200.54, 145.61, 145.25, 158.63, 139.49, 149.95, 151.3, 253.44, 193.94, 157.57, 179.19, 161.46, 143.29, 151.05, 242.59, 238.92, 243.29, 245, 243.95, 244, 243.99, 244.02, 242.93, 242.91, 242.75, 242.82, 149.64, 166.81, 146.19, 143.85, 0]
    line [9.6, 100.17, 132.61, 129.98, 153.07, 161.98, 186.97, 178.1, 157.4, 197.08, 142.15, 141.77, 155.14, 136, 146.47, 147.82, 249.97, 190.52, 154.33, 175.66, 157.96, 139.75, 147.54, 239.88, 235.4, 239.79, 241.49, 240.44, 240.49, 240.49, 240.51, 239.42, 239.41, 239.25, 239.32, 146.14, 162.53, 142.7, 140.37, 0]
Loading

Deterministic fixture · required contract

The fixture exercises 15 routes: 8 are expected to emit rows and 7 intentionally exercise empty, loading, or timeout behavior.

Metric Base HEAD Δ
Run status success success —
Extracted rows / contract 40 / 40 40 / 40 0 (0.00%)
Contract fill 100.00% 100.00% 0.00 pp (0.00%)
Sites with rows 8 / 15 8 / 15 0 (0.00%)
Sites meeting row contract 15 / 15 15 / 15 0 (0.00%)
Unexpected empty sites 0 0 0
Partial-row sites 0 0 0
Site outcomes extracted: 7; HTTP error + rows: 1; empty: 3; timeout + empty: 4 extracted: 7; HTTP error + rows: 1; empty: 3; timeout + empty: 4 —
Observed duration 19.88 s 19.87 s -0.00 s (-0.01%)
Estimated CPU 0.44 s 0.38 s -0.06 s (-13.15%)
Peak PSS 57.64 MiB 57.86 MiB +0.22 MiB (+0.38%)
Peak RSS 60.98 MiB 61.29 MiB +0.32 MiB (+0.52%)
Peak threads 18 18 0 (0.00%)
Mismatched sites 0 0 0
Timeout with items 0 0 0

Full HTML, JSON, CSV, logs, and page snapshots: workflow run and full spider-bench-results artifact.

The public-web A/B is informational. The exact HEAD fixture contract runs as a separate required CI check; timing and public-site content deltas remain non-blocking.

@github-actions

github-actions Bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Sequential Navigation Soak A/B

✅ HEAD completed the 200-navigation resilience and memory observation.

One browser process, one target, and one CDP session navigate CSDN → SegmentFault → Huaban → example.com repeatedly. This run issued 200 Page.navigate commands per binary.

Common ancestor 7540d64247 → HEAD 42de4ab088; benchmark order: base-first; workflow: success.

Session resilience

Metric Base HEAD
Attempted / planned 200 / 200 200 / 200
Direct observable pass 200 / 200 200 / 200
Failures / recovered 0 / 0 0 / 0
Recovery failures 0 0
Lifecycle order violations 0 0
Network order violations 0 0
Wall time 308.6 s 313.3 s

A public-page failure is reported separately from an unrecoverable session. The soak requires all navigation attempts, zero failed recovery, zero lifecycle/network ordering violations, and complete resource evidence.

Process-tree memory

Metric Base HEAD Δ
Boundary samples 200 200 0
Boundary RSS samples 200 200 0
Boundary PSS samples 200 200 0
Periodic peak RSS 221.0 MiB 218.4 MiB -2.5 MiB
Periodic peak PSS 217.7 MiB 214.9 MiB -2.9 MiB
RSS · first 10 avg 164.7 MiB 166.2 MiB +1.5 MiB
RSS · last 10 avg 164.2 MiB 162.3 MiB -1.9 MiB
RSS · last − first window -0.5 MiB -3.9 MiB -3.4 MiB
RSS · warm slope / 100 nav +1.5 MiB +0.0 MiB -1.5 MiB
PSS · first 10 avg 161.5 MiB 162.8 MiB +1.3 MiB
PSS · last 10 avg 160.8 MiB 158.8 MiB -2.0 MiB
PSS · last − first window -0.7 MiB -4.0 MiB -3.3 MiB
PSS · warm slope / 100 nav +1.6 MiB -0.1 MiB -1.7 MiB
Peak file descriptors 64 63 -1
Peak threads 31 31 0

HEAD memory by 50-navigation quarter

HEAD range Avg RSS Final RSS Peak RSS Avg PSS Final PSS Peak FD
1–50 164.3 MiB 152.7 MiB 212.2 MiB 161.0 MiB 149.8 MiB 50
51–100 164.1 MiB 136.5 MiB 215.1 MiB 161.0 MiB 133.3 MiB 52
101–150 163.8 MiB 153.0 MiB 194.8 MiB 160.5 MiB 150.0 MiB 54
151–200 164.5 MiB 137.6 MiB 205.2 MiB 161.3 MiB 134.1 MiB 51

Raw reports and per-navigation boundary samples: workflow run and full sequential-navigation-soak-results artifact.

Public-site timing and memory are observational. Use the A/B deltas and trend shape as evidence, not as a deterministic performance threshold.

@github-actions

github-actions Bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown

CI Regression Report

Source CI run · source state at render: in_progress · artifacts: 5/5

Check Status Signal
Release regression ✅ HEAD/base failures 0/0; raw binary +0.043216%
Frontend differential ❌ 1,017/1,020 cases matched; 3 issues
Agent episodes ✅ 8/8 Moli episodes passed; 0 failures
Runtime/CDP contracts ✅ 26 contract cases; 0 failures
CDP smoke ✅ 48/48 groups passed; 535 scenarios
Release regression — ✅ HEAD/base failures 0/0; raw binary +0.043216%

Package and image size

Metric Base HEAD Delta Delta %
Raw binary 146.26 MiB 146.33 MiB +64.73 KiB +0.043216%
Stripped binary 100.36 MiB 100.40 MiB +44.00 KiB +0.042815%
gzip binary 50.06 MiB 50.07 MiB +18.20 KiB +0.035505%
Rootfs 153.16 MiB 153.23 MiB +70.00 KiB +0.044631%
gzip rootfs 58.83 MiB 58.85 MiB +22.06 KiB +0.036623%

Startup latency and PSS

Case Base p50 HEAD p50 Delta Base PSS HEAD PSS Delta
Serve ready 27.31 ms 27.16 ms −0.16 ms 5.51 MiB 5.02 MiB −495.50 KiB
CDP first page 52.58 ms 48.72 ms −3.86 ms 5.06 MiB 3.77 MiB −1.29 MiB
CDP warm page 13.85 ms 12.12 ms −1.74 ms 49.17 MiB 50.14 MiB +990.50 KiB
CLI about:blank 15.00 ms 13.39 ms −1.61 ms 3.81 MiB 4.04 MiB +239.00 KiB
CLI local JS 18.10 ms 17.34 ms −0.76 ms 3.30 MiB 3.05 MiB −258.50 KiB

Concurrency matrix

Concurrency Base p50 HEAD p50 Delta Base PSS HEAD PSS Delta HEAD failures Unstable B/H
1 16.69 ms 16.14 ms −0.56 ms 617.00 KiB 643.00 KiB +26.00 KiB 0 0/0
5 20.61 ms 18.61 ms −2.01 ms 22.40 MiB 26.70 MiB +4.30 MiB 0 0/0
10 18.83 ms 20.31 ms +1.48 ms 26.81 MiB 22.60 MiB −4.21 MiB 0 0/0
25 19.55 ms 19.39 ms −0.16 ms 26.31 MiB 26.65 MiB +348.50 KiB 0 0/0
100 20.37 ms 19.53 ms −0.84 ms 26.82 MiB 17.85 MiB −8.97 MiB 0 0/0
Frontend differential — ❌ 1,017/1,020 cases matched; 3 issues
Match DOM mismatch Diagnostic mismatch Moli error Reference error Infrastructure error Mismatched frames Duration
1,017 3 0 0 0 0 12 6m 39.78s

First failing cases

  • react/history-navigation-boundaries/child-context-history — dom_mismatch · first difference $.frames[2].dom.children[1].children[2].children[1].children[0].children[1].children[0].children[0].children[0].contentDocument.children[1].children[2].children · frames platform-1, platform-2, ready +1 more
  • vue/history-navigation-boundaries/child-context-history — dom_mismatch · first difference $.frames[2].dom.children[1].children[2].children[1].children[0].children[1].children[0].children[0].children[0].contentDocument.children[1].children[2].children · frames platform-1, platform-2, ready +1 more
  • angular/history-navigation-boundaries/child-context-history — dom_mismatch · first difference $.frames[2].dom.children[1].children[2].children[1].children[0].children[1].children[0].children[0].children[0].contentDocument.children[1].children[2].children · frames platform-1, platform-2, ready +1 more
Agent episodes · Moli vs Chromium — ✅ 8/8 Moli episodes passed; 0 failures
Fast contract Episodes Passed Assertions Ready p50 Episode p50
Moli 8 8 47/47 3.09 ms 25.04 ms
Chromium 8 8 47/47 281.29 ms 87.15 ms
Operation p50 Chromium Moli Delta Delta %
navigate 40.61 ms 6.61 ms −33.99 ms −83.71%
observe 0.86 ms 0.82 ms −0.04 ms −4.94%
fill 3.86 ms 3.14 ms −0.72 ms −18.69%
click 5.17 ms 3.40 ms −1.77 ms −34.18%
Idle-resource episode Peak RSS Peak PSS Average CPU Peak CPU Peak processes Sampler
Moli 64.04 MiB 62.29 MiB 0.65% 10.00% 1 ✅
Chromium 1289.86 MiB 412.68 MiB 2.21% 92.08% 13 ⚠️ PSS partial
Runtime and CDP session contracts — ✅ 26 contract cases; 0 failures
Suite Cases Failures Median case p50 Median case p95 Median peak PSS p50
Synthetic fetch 13 0 17.91 ms 19.49 ms 640.00 KiB
Long-lived CDP session 13 0 18.95 ms 19.22 ms —
CDP smoke — ✅ 48/48 groups passed; 535 scenarios

Workers: 4 · cumulative group time: 145.85 s · failed groups: 0

Slowest group Scenarios Duration Status
target-lifecycle 24 16.62 s ✅
chromium-cdp 56 11.41 s ✅
multi-page 45 11.29 s ✅
dom-input 27 9.40 s ✅
layout-screenshot 5 7.63 s ✅

All artifact fields are parsed by the trusted default-branch renderer; missing or invalid inputs remain visible as unavailable.

lanyue-llk and others added 4 commits September 23, 2026 19:57
@lanyue-llk @ldm0
fix(input): preserve activation and navigation boundaries
0a02168
@ldm0
fix(input): preserve Enter cancellation and multi-character text
9e66c51 
Dispatch a cancelable insertLineBreak beforeinput before implicit form
submission, including default submit button activation. Require a standalone
CR when inferring Enter from character text.

Cover combined keydown, standalone char, and embedded-CR input so text is
preserved without accidental submission.

Temporarily ignore the two Chromium-verified iframe overlay click tests
pending separate implementation fixes.
@ldm0
fix(input): dispatch InputEvent metadata for text edits
0780a17 
Dispatch trusted beforeinput and input events with operation-specific
inputType and data for text controls and contenteditable editing. Keep
beforeinput cancelable and report input.data after text normalization
and maxlength truncation.

Cover keyboard and CDP insertion, cancellation, deletion, and textarea
line breaks with 57 regression scenarios.
@ldm0
refactor(input): centralize editing and native element clicks
42de4ab
@ldm0
ldm0 merged commit 1933cec into main Sep 23, 2026
17 of 18 checks passed
@ldm0 ldm0 mentioned this pull request Sep 23, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ldm0 @lanyue-llk