Repository navigation
feat(style): expose preferred text scale environment - #1
Open
lanyue-llk wants to merge 3 commits into
Open
lanyue-llk wants to merge 3 commits into
lanyue-llk wants to merge 3 commits into
Conversation
This was referenced Sep 24, 2026
This was referenced Sep 30, 2026
lanyue-llk
force-pushed
the
codex/preferred-text-scale
branch
from
September 30, 2026 04:15
4e9bf17 to
3d44ed3
Compare
lanyue-llk
force-pushed
the
codex/preferred-text-scale
branch
from
October 8, 2026 03:43
3d44ed3 to
0db9840
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Expose preferred text scale through Stylo's CSS environment so Moli can update dependent styles through normal cascade and invalidation.
Overall design
Full-size overview · All current PR diagrams
Implementation flow (Mermaid)
Scope and integration
Moli #731 pins head
0db9840e674f6ad45c4df06961501b1a26bd2827and owns per-target updates and invalidation.Reproduce the consumer badcase
The original browser-client scenario is
v4_cdp_emulation_setemulatedostextscale. Moli lacked the command/state propagation and Stylo lacked the environment value. The full reproduction therefore runs through Moli #731's integration test, which pins this Stylo revision.The fixture uses
font-size:calc(16px * env(preferred-text-scale,1))andwidth:calc(20px * env(preferred-text-scale,1)). It also updates color-scheme media preferences to check that scale changes preserve other environment state.Use the repository's Rust toolchain and cargo-nextest. Expected result: both selected tests pass; failures show expected/actual CSS values. Fixtures are local and need no website deployment. #731's pinned Cargo dependency is the Stylo #1 head
0db9840e674f6ad45c4df06961501b1a26bd2827; the same source also preserves the WebMCP selector APIs.Evaluation reports
The consumer integration tests distinguish fixed font sizes from environment-dependent sizes and exercise recomputation after scale changes.