Conversation
…erVR GPUs This patch is from @nicman23: https://gitlab.freedesktop.org/nicman23/mesa/-/commit/d3eec9f0c4a45a96dc6ea7cb4f469e49cf64d3ed The previous implementation used a fixed-size static array of 16 VkPhysicalDevice handles, which could cause a segfault on certain drivers (notably PowerVR DXT-48 on Pixel 10 devices) when the driver's behavior with the pre-allocated array differed from expectations. Replace the static array with dynamic allocation: i. Query the actual device count first by calling EnumeratePhysicalDevices with NULL ii. Allocate the array based on the returned count iii. Handle VK_INCOMPLETE by reallocating with a larger size iv. Add proper error handling and memory cleanup This follows the Vulkan specification more closely and should be more robust across different driver implementations. Fixes: segfault on PowerVR DXT-48 GPU
lfdevs
force-pushed
the
dev/wrapper
branch
9 times, most recently
from
September 14, 2026 13:32
6969fec to
ccb3433
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tested compilation and runtime on my pixel 10 and pipetto seams to be the defacto upstream of the project with various fixes and qol