Repository navigation
Cut Graph1x 1.0.0 - #10
Merged
Merged
Conversation
The RC soaked with zero API delta (PublicAPI.Unshipped.txt holds only the nullable directive), so 1.0.0 ships the exact surface promoted at 0.7.0. The changelog and README now state the SemVer compatibility commitment the analyzer lock enforces at build time. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Wire the new assets/logo.png (letterboxed to 128x128, NuGet's recommended icon size) into the README header and into the packed nupkg via PackageIcon, following the same Pack="true" pattern already used for the README.
The packed README referenced assets/logo.png, a path that does not exist inside the nupkg; NuGet.org only renders readme images from absolute URLs on trusted domains, so the 1.0.0 package page would show a broken image. raw.githubusercontent.com is on the allowlist and works on GitHub too. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Capture conventions settled during the 0.x cycle so they are recorded before the stable release: constant-like private static readonly naming and the test-project XML-doc exemption, editorconfig-backed enforcement, explicit test-scope precedence over the edge-case checklist, PR-only squash merges to the protected default branch, and a new architecture.md separating physical layout rules from logical design principles. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Credit Claude Fable's role in designing, implementing, and reviewing each milestone alongside the test-first workflow.
NuGet.org does not resolve relative links, so the GitHub README's CHANGELOG/LICENSE links dead-ended on the package page, and its contributor-facing sections (badges, Building, Performance, Releasing, Project layout, Acknowledgments) are noise for a package consumer. Add README.nuget.md — logo, description, Goals, a trimmed Status with the capability table, full Usage, and License — with every link absolute, and point PackageReadmeFile/pack at it instead of the root README. The GitHub README stays the full contributor-facing document.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PackageIcon, letterboxed to the recommended 128x128 square with no distortion), and credits the test-first collaboration with Claude Fable in a new Acknowledgments section..editorconfigwithEnforceCodeStyleInBuild; a newarchitecture.mdrule documents repo/solution layout conventions.Test plan
dotnet build Graph1x.sln— 0 warnings, 0 errorsdotnet test Graph1x.sln— 831/831 passing on both net8.0 and net10.0dotnet pack src/Graph1x/Graph1x.csproj -c Release— verifiedicon.pngis present in the resulting.nupkgat the package root with no NU5048/NU5051 warnings🤖 Generated with Claude Code