Move pack and copack operations to <fn/algebra.hpp> - #442
Merged
Merged
Conversation
Bronek
added this pull request to stack #445
September 28, 2026 20:14
🤖 Augment PR SummarySummary: This PR extracts the data-algebra surface from Changes:
copack.hpp now supports void transforms without an additional pack include; direct use of the moved algebra operations requires algebra.hpp.
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
Bronek
force-pushed
the
bronek/algebra_header
branch
from
September 28, 2026 20:38
47bb787 to
60419e6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Bronek
force-pushed
the
bronek/algebra_header
branch
4 times, most recently
from
September 29, 2026 20:46
f2f7069 to
671c9b2
Compare
|
Bronek
removed this pull request from stack #445
September 29, 2026 21:20
Bronek
added this pull request to stack #446
September 29, 2026 21:21
Bronek
removed this pull request from stack #446
September 29, 2026 21:24
Bronek
force-pushed
the
bronek/void_unit_factor
branch
from
September 29, 2026 21:30
0a301b4 to
850ac60
Compare
Bronek
force-pushed
the
bronek/algebra_header
branch
2 times, most recently
from
September 29, 2026 21:32
52aa1fa to
9eefc44
Compare
Bronek
force-pushed
the
bronek/void_unit_factor
branch
from
September 29, 2026 21:32
850ac60 to
5299f38
Compare
Separate the data types from operator&, conjoin, disjoin and the carrier join helpers. Keep the data operator& overload set together in algebra.hpp. Make copack.hpp include pack.hpp so void transforms need no extra include. Carrier headers include algebra.hpp; direct users of the moved operations must include it. Move the corresponding tests to algebra.cpp. Assisted-by: Claude:claude-opus-5-5 Assisted-by: Codex:gpt-6-astra
Bronek
force-pushed
the
bronek/algebra_header
branch
from
September 29, 2026 21:34
9eefc44 to
cb4a64e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move data
operator&,conjoin,disjoin, and the carrier join helpers to<fn/algebra.hpp>.Breaking: direct users of the moved operations must include
<fn/algebra.hpp>. Carrier headers already include it. Code usingcopackthrough<fn/pack.hpp>must include<fn/copack.hpp>explicitly.Make
<fn/copack.hpp>include<fn/pack.hpp>so void transforms need no extra include. Move the corresponding tests totests/fn/algebra.cpp.Assisted-by: Claude:claude-opus-5-5
Assisted-by: Codex:gpt-6-astra