Reject apply-trait queries on an incomplete pack or copack - #443
Merged
Merged
Conversation
Bronek
added this pull request to stack #445
September 28, 2026 20:14
🤖 Augment PR SummarySummary: This PR prevents 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
Bronek
force-pushed
the
bronek/incomplete_apply_operand
branch
from
September 28, 2026 20:38
3b6e754 to
350f6c0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Bronek
force-pushed
the
bronek/incomplete_apply_operand
branch
4 times, most recently
from
September 29, 2026 20:46
1eeadd6 to
6ed28f4
Compare
Bronek
removed this pull request from stack #445
September 29, 2026 21:20
Bronek
added this pull request to stack #446
September 29, 2026 21:21
Bronek
removed this pull request from stack #446
September 29, 2026 21:24
Bronek
force-pushed
the
bronek/incomplete_apply_operand
branch
from
September 29, 2026 21:30
6ed28f4 to
b661fa8
Compare
Bronek
force-pushed
the
bronek/algebra_header
branch
from
September 29, 2026 21:30
671c9b2 to
52aa1fa
Compare
Bronek
force-pushed
the
bronek/incomplete_apply_operand
branch
from
September 29, 2026 21:32
b661fa8 to
6d2c3d0
Compare
Bronek
force-pushed
the
bronek/algebra_header
branch
2 times, most recently
from
September 29, 2026 21:34
9eefc44 to
cb4a64e
Compare
Bronek
force-pushed
the
bronek/incomplete_apply_operand
branch
from
September 29, 2026 21:34
6d2c3d0 to
cd7c718
Compare
Require complete pack and copack operands before querying their apply members. This prevents caching a false result before the defining header is included. Typelist queries still work from template arguments alone. Assisted-by: Claude:claude-opus-5-5 Assisted-by: Codex:gpt-6-astra
Bronek
force-pushed
the
bronek/incomplete_apply_operand
branch
from
September 29, 2026 21:38
cd7c718 to
8f7f465
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject
applytrait queries on incompletepackorcopackoperands. Previously, a query could cachefalseorvoideven after the defining header was included. Include<fn/pack.hpp>or<fn/copack.hpp>before querying.typelist_applicablestill works from template arguments alone. Compilation failures cannot yet be tested in the suite; document the untested negative beside its positive controls.Assisted-by: Claude:claude-opus-5-5
Assisted-by: Codex:gpt-6-astra