Rename <fn/monadic.hpp> to <fn/traits.hpp>, guard `monadic_invoca… - #444
Merged
Merged
Conversation
Bronek
added this pull request to stack #445
September 28, 2026 20:14
🤖 Augment PR SummarySummary:
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
|
|
||
| template <typename Functor, typename V, typename... Args> | ||
| concept _monadic_invocable | ||
| = _complete_class<Functor>() && _some_monadic_type<V> && ::std::invocable<typename Functor::apply, V, Args...>; |
There was a problem hiding this comment.
include/fn/detail/traits.hpp:39: A complete Functor can still have a forward-declared nested apply; this evaluates std::invocable on an incomplete callable, whose result can change after apply is defined (and violates its incomplete-type precondition). Thus the new guard does not provide the stated order-independent monadic_invocable result for user-defined verbs.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Bronek
force-pushed
the
bronek/traits_header
branch
from
September 28, 2026 20:38
8b90ec3 to
9e087c2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Bronek
force-pushed
the
bronek/traits_header
branch
4 times, most recently
from
September 29, 2026 20:46
08ca67f to
9ca319e
Compare
Bronek
removed this pull request from stack #445
September 29, 2026 21:20
Bronek
added this pull request to stack #446
September 29, 2026 21:21
Bronek
removed this pull request from stack #446
September 29, 2026 21:24
Bronek
force-pushed
the
bronek/incomplete_apply_operand
branch
from
September 29, 2026 21:30
6ed28f4 to
b661fa8
Compare
Bronek
force-pushed
the
bronek/traits_header
branch
2 times, most recently
from
September 29, 2026 21:32
18185f0 to
57a6e1e
Compare
Bronek
force-pushed
the
bronek/incomplete_apply_operand
branch
2 times, most recently
from
September 29, 2026 21:34
6d2c3d0 to
cd7c718
Compare
Bronek
force-pushed
the
bronek/traits_header
branch
2 times, most recently
from
September 29, 2026 21:38
50c0ccd to
b9b6592
Compare
Bronek
force-pushed
the
bronek/incomplete_apply_operand
branch
from
September 29, 2026 21:38
cd7c718 to
8f7f465
Compare
Bronek
changed the base branch from
bronek/incomplete_apply_operand
to
main
September 29, 2026 21:39
…ble` Rename the public traits header and fold detail/monadic.hpp into detail/traits.hpp. Move some_in_place_type alongside the other traits. Require complete functor types in monadic_invocable to prevent concept satisfaction from changing after a definition. Share the completeness check with the apply traits. Direct includes of monadic.hpp must change to traits.hpp. Assisted-by: Claude:claude-opus-5-5 Assisted-by: Codex:gpt-6-astra
Only `static_assert` exercised it, so coverage never saw its body. Assisted-by: Claude:claude-opus-5-5
A complete verb may still only declare its nested `apply`, as libfn's own verbs do before defining it out of line. Asked in between, `std::invocable` saw an incomplete type: libstdc++ rejects that from inside <type_traits>, while libc++ answered `false` and kept it after `apply` was defined. The guard now checks `apply` too, with the same diagnostic. Assisted-by: Claude:claude-opus-5-5
Bronek
force-pushed
the
bronek/traits_header
branch
from
September 29, 2026 21:43
b9b6592 to
56e2d2f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
<fn/monadic.hpp>to<fn/traits.hpp>and movesome_in_place_typethere.Breaking: replace direct includes of
<fn/monadic.hpp>; there is no compatibility header.Require complete functor types in
monadic_invocable, including user-defined classes and unions. This prevents concept satisfaction from changing after the definition. Share the completeness check with theapplytraits and add positive controls for the guard; the suite cannot yet test compilation failures.Assisted-by: Claude:claude-opus-5-5
Assisted-by: Codex:gpt-6-astra