Skip to content

✨ Added scatter_span functionality #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PhazonicRidley wants to merge 10 commits into
base: main
Choose a base branch
from
Open

✨ Added scatter_span functionality #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3eceb0f
:sparkles: Made the base structure for scatter_span and scatter_array
PhazonicRidley May 11, 2026
3f7f09c
:truck: Factored out iterator into its own file
PhazonicRidley May 14, 2026
435f00e
Added subscatterspan
PhazonicRidley Jun 4, 2026
54771bb
Fixed a lot of ctor and lifetime logic and added basic smoke tests
PhazonicRidley Jun 5, 2026
4307497
[BROKEN] Added subspan tests
PhazonicRidley Jun 5, 2026
094c557
Fixed length to adhere to final length and corrected math for subspans
PhazonicRidley Jun 6, 2026
75c7cb1
Fixed corner cases with subspan and length, updated iterator to conta…
PhazonicRidley Jun 7, 2026
30406da
Completed subscatterspan and removed potential UB with it as well
PhazonicRidley Jun 8, 2026
e9098d1
Documentation
PhazonicRidley Jun 9, 2026
387b994
Fixed linting issues
PhazonicRidley Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
"words": [
"scatter",
"span",
"libhal"
"libhal",
"spanable",
"subssp"
]
}

2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,4 @@ CMakeUserPresets.json
.vscode/launch.json

# Allowed for clangd resolver script
!.vscode/settings.json
!.vscode/settings.json

@kammce kammce Jun 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather us just remove the line not allowing .vscode into the code base.

@PhazonicRidley PhazonicRidley Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to allow explicit use of the clangd resolver for this repo. Without this, developers will need to manually configure this for every machine as this is a non-standard way of interacting with clangd. If we want, we can add a neovim analog as well. Its not too uncommon to see editor metadata that is relevant and needed for a specific repo to appear in that repo

3 changes: 2 additions & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{
"clangd.path": "./compile_commands_clangd_resolver.py"
}
}

1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ libhal_project_init()
libhal_add_library(scatter-span
MODULES
modules/scatter_span.cppm
modules/core.cppm
)

libhal_apply_compile_options(scatter-span)
Expand Down
2 changes: 1 addition & 1 deletion conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def generate(self):

def build(self):
cmake = CMake(self)
cmake.configure()
cmake.configure(cli_args=["-Wno-dev"])
Comment thread
PhazonicRidley marked this conversation as resolved.
cmake.build()
if not self.conf.get("tools.build:skip_test", default=False):
cmake.ctest(["--output-on-failure"])
Expand Down
Loading
Loading