You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up to the review on #1005: the PostgreSQL Clients link that README.md carries in its "Listed by the PostgreSQL project" row was missing from the other translations.
Adds <a href="https://wiki.postgresql.org/wiki/PostgreSQL_Clients#LibreDB_Studio">PostgreSQL Clients</a> between News and Software Catalogue in README_ja.md, README_es.md, README_ur.md and README_hi.md — same position and URL as the English README. Anchor text is left in English, consistent with the other link labels (News, Software Catalogue, Community Guide to GUI Tools) in those files.
Thanks for merging — and good eye on the website. I checked, and that preview frame embeds peptideatlas.pages.dev, which currently sends X-Frame-Options: DENY (and frame-ancestors 'none'), so the browser refuses to render it inside the iframe. The fix is straightforward: relax the frame-ancestors policy on that site to allow the portfolio origin, or swap the live embed for a static screenshot. I'll get it sorted shortly.
Sorted — the preview now renders a static screenshot of the Peptide Atlas hero inside the frame instead of the blocked live embed, and clicking it still opens the live site as before. Thanks again for the heads-up.
Small update for the record: I went with the other option — the Peptide Atlas site now allowlists the portfolio origin in its CSP frame-ancestors instead of serving a static screenshot, so the preview on the site is the live, interactive embed again. Clickjacking protection is unchanged for every other origin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
documentationImprovements or additions to documentation
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firendly note: you might have missed this. image is not loading on your website
Follow-up to the review on #1005: the PostgreSQL Clients link that
README.mdcarries in its "Listed by the PostgreSQL project" row was missing from the other translations.<a href="https://wiki.postgresql.org/wiki/PostgreSQL_Clients#LibreDB_Studio">PostgreSQL Clients</a>between News and Software Catalogue inREADME_ja.md,README_es.md,README_ur.mdandREADME_hi.md— same position and URL as the English README. Anchor text is left in English, consistent with the other link labels (News,Software Catalogue,Community Guide to GUI Tools) in those files.README_zh.mdis intentionally untouched because docs(zh): proofread README_zh.md — rewrite the stale TLS note and six smaller fixes #1005 already adds the link there.node scripts/readme-check.mjspasses.Related: #974 (translation proofreads).