Skip to content

feat: compact table counts and add count query actions - #926

Merged
cevheri merged 2 commits into
libredb:mainfrom
DevvoLazza:fix/table-count-actions
Sep 24, 2026
Merged

feat: compact table counts and add count query actions#926
cevheri merged 2 commits into
libredb:mainfrom
DevvoLazza:fix/table-count-actions

Conversation

@DevvoLazza

@DevvoLazza DevvoLazza commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Million-row catalog counts currently occupy too much space on desktop and use thousands-only formatting on mobile. Both explorers now use compact counts and offer an editable count query from the table menu.

Type of Change

  • New feature
  • Documentation update
  • Test addition or update

Related Issue

Closes #702

Changes Made

  • Share K/M/B/T formatting between desktop and mobile. Tooltips preserve the full reported figure and explain that catalog counts are estimates on most engines.
  • Add Generate Count Query beside Generate Query: qualified SQL with dialect quoting and terminators, COUNT_BIG on SQL Server, or MongoDB's count/filter document. Unsupported key grammars and derived prefix groupings receive no action.
  • Open an editable tab without executing the count, so users can add filters before Run. Preserve the embedded workspace's navigation guard during pending object edits.

Testing

  • Full suite with coverage: 545 files passed; 17,600 tests passed, 71 skipped. Twelve Helm files were not run because Helm is unavailable.
  • Format, lint, typecheck, knip, README parity, chart version, channel showcase, and security checks passed. Lint retains 240 existing warnings and has zero errors.
  • Production application build, library build, and package type-resolution checks passed.
  • Generated SQL counted a real SQLite table containing 1,553,900 rows; adding a filter returned 7. Browser validation using the actual explorer components and tab manager confirmed compact badges, explicit Run, MongoDB query generation, and the absent Redis count action.
  • Modified source files have 100% line coverage. The global coverage gate reports 99.99% solely because unchanged src/instrumentation.ts:32-36 is covered by a POSIX permission test skipped on Windows. Linux CI must verify the required 100% gate.

Environment: Windows, Node.js 24.16.0, Bun 1.4.2, LibreDB Studio 0.16.0. Browser catalog/provider data were fixtures; no live PostgreSQL/MySQL or MySQL catalog-drift verification was possible locally.

Checklist

  • Reviewed the diff and updated documentation and tests
  • New and existing available tests pass locally
  • No new warnings, dependency changes, lockfile changes, generated files, or local configuration included
  • Required CI test job passes the 100% line-coverage gate

@cevheri cevheri added loop:needs-info Maintainer-loop task blocked on human-reviewed clarification and removed loop:needs-info Maintainer-loop task blocked on human-reviewed clarification labels Sep 17, 2026
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@cevheri cevheri added the loop:needs-info Maintainer-loop task blocked on human-reviewed clarification label Sep 17, 2026
@cevheri

cevheri commented Sep 17, 2026

Copy link
Copy Markdown
Member

rebase, fix CI

@DevvoLazza

DevvoLazza commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

Hi, I won’t be able to work on this today or tomorrow as I’m away from home. As soon as I’m back, I’ll continue and finish the remaining fixes.

@cevheri

cevheri commented Sep 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

friendly ping: The red check is ours: chart:check dies in 42 seconds because the branch is 94 commits behind and still carries chart 0.1.64, which main has released. I ran the gates it never reached and format, lint, typecheck, knip, build and build:lib all pass. The rebase also restores Functional Smoke (PostgreSQL), so the PostgreSQL repro can come from CI.

Three fixes for the same push:

  • tests/unit/lib/table-count.test.ts expects a trailing semicolon on the Trino and OpenSearch rows. Both declare statementTerminator: "none", with the measurement written beside it at trino/index.ts:392 and search/index.ts:731. Your generator is right, the fixtures are not. Build each row from the provider's own getCapabilities(). Trino also quotes with ", and libSQL's defaultPort is 8080.
  • The exact count left the accessible name: row-menu.test.tsx:710 now pins orders 1.2K where it read orders 1,234. title is not consulted once the element has text, so add aria-label={formatRowCountTitle(object.rowCount)} to the count span in TreeRow.tsx and a screen reader keeps the full figure.
  • Redis and LibreDB lose a menu item and no doc records it: docs/providers/redis.md:635 says "Four menu actions", docs/providers/libredb.md:439 says "Two", and docs/ADDING_A_PROVIDER.md:680 lists the same set. Code, provider doc and tests move together here.

Putting the mobile title on the parent slot rather than the pointer-events-none badge was the right call. Ping me when it is pushed.

@cevheri

cevheri commented Sep 21, 2026

Copy link
Copy Markdown
Member

Hi @DevvoLazza I hope everything is ok
any update this pr

@DevvoLazza

DevvoLazza commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

I've been dealing with some family issues lately, but as soon as I get back on my feet, I'll be back online.

@cevheri cevheri self-assigned this Sep 23, 2026
@cevheri

cevheri commented Sep 23, 2026

Copy link
Copy Markdown
Member

I've been dealing with some family issues lately, but as soon as I get back on my feet, I'll be back online.

Hi @DevvoLazza, no worries about the PR. We're a team here, so I'll take it over and move it forward.

Take care, and don't worry about this one. We'll handle it from here.

@libredb libredb locked as resolved and limited conversation to collaborators Sep 23, 2026
@cevheri cevheri added enhancement New feature or request and removed loop:needs-info Maintainer-loop task blocked on human-reviewed clarification labels Sep 23, 2026
DevvoLazza and others added 2 commits September 24, 2026 13:07
@DevvoLazza @cevheri
feat: add compact table counts and count query actions
48104e8
@cevheri
fix(explorer): finish the count action review items (libredb#702)
6c68f8a 
Build the count census from each provider's own getCapabilities() so the
fixtures cannot claim a terminator or quote the provider does not declare.
The old rows expected a trailing semicolon on Trino and OpenSearch, which
both declare statementTerminator "none".

Move the gate to offersCountQuery in lib/db/types.ts beside the other
row-menu gates, and refuse PromQL, which arrived after this branch: its
count() counts series, not rows.

Keep the exact figure in the row's accessible name with an aria-label on
the count span, since title is not read once the element has text.

Record the withheld action in the Redis, LibreDB, Prometheus and
ADDING_A_PROVIDER docs.
@cevheri
cevheri force-pushed the fix/table-count-actions branch from ce876cf to 6c68f8a Compare September 24, 2026 10:17
@cevheri
cevheri merged commit 8266a9f into libredb:main Sep 24, 2026
24 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cevheri cevheri cevheri approved these changes

Assignees

@cevheri cevheri

@DevvoLazza DevvoLazza

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] nicer way to display and query the table count

2 participants

@DevvoLazza @cevheri