Conversation
- Trino row: '连接所固定 catalog' was missing 的, breaking the clause
('schema tree for the catalog the connection pins').
- Agent-mode limits: '运行还没有建立' mistranslated 'before a run is
opened' — the run is never created at all.
Full read-through as a native speaker; the rest of the file reads
accurately and idiomatically against the English original.
Part of libredb#974
|
thanks @t957095 and welcome |
cevheri
added
the
loop:needs-moderator-action
InnoxCodes
left a comment
InnoxCodes
left a comment
There was a problem hiding this comment.
Checked both fixes against the English README. The Trino row now reads correctly (连接所固定的 catalog), and the English says the workflow is refused "before a run is opened", so 根本不会创建运行 is the better wording. node scripts/readme-check.mjs passes on this branch.
One note: #1005 says it includes both of these fixes and adds more, so the two PRs overlap and only one of them needs to be merged.
|
Closing this per the review below: #1005 includes both of these fixes and adds more, so only one of the two PRs needs to merge. Thanks @cevheri for the welcome and @InnoxCodes for the review. |
|
Thanks, just a quick reminder: could you leave a comment so I can assign this issue to you. |
3 participants
Full native-speaker proofread of
README_zh.mdagainst the English original, per #974. The file is in genuinely good shape overall; two confirmed errors fixed:连接所固定 catalog 的 information_schema schema 树was missing 的, leaving a broken clause. Source:information_schema schema tree for the catalog the connection pins.运行还没有建立mistranslatesbefore a run is opened— the run is never created, not merely 'not yet established'. Fixed to 根本不会创建运行.Everything else checked out as accurate and idiomatic, including the engine table, the agent pipeline description, and the distribution section.
Part of #974