Repository navigation
fix(admin): name the schema on an Operations table row - #984
Merged
cevheri merged 1 commit intoSep 19, 2026
Merged
Conversation
Two tables that share a name in different schemas rendered as identical rows, so an operator choosing between them could not tell which was which. The row now prints `schema.table`: the schema sits in a muted span OUTSIDE the truncating span, so a long table name still truncates at max-w-[160px] and the schema survives it. The component test pins the schema on the row (it goes red the moment the schema is dropped) and pins the truncation on the table name. The stale comment in the deep-link collision test, which recorded that the row did not print its schema, is corrected. Closes libredb#977
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cevheri
approved these changes
Sep 19, 2026
Member
|
thanks and welcome |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The admin Operations page listed tables without their schema, so two tables that share a name in different schemas rendered as identical rows and an operator choosing between them could not tell which was which. The row now prints
schema.table.Type of Change
Related Issue
Closes #977
Changes Made
src/components/admin/tabs/OperationsTab.tsx: the table row now renders the schema in a muted span outside the truncating span, followed by.and the table name. The table name keeps its existingtruncate max-w-[160px], so a long name still truncates and the schema survives it.tests/components/admin/OperationsTab.test.tsx: added a test that pins the schema on the row for two schemas sharing a label (it goes red if the schema is dropped), and a test that pins the truncation on the table name. Corrected the now-stale comment in the deep-link collision test that recorded the row did not print its schema.Testing
Ran locally (Bun 1.4.2, linux-x64):
bun run format— cleanbun run lint— 0 errors (228 pre-existing warnings)bun run typecheck— cleanbun run knip— cleanbun tests/run-tests.ts tests/components— 92 files, 2983 tests passbun tests/run-tests.ts tests/components/admin/OperationsTab.test.tsx --coverage --merge-into=coverage/lcov.info—OperationsTab.tsx507/507 lines (100%)Not run locally:
bun run build,bun run build:lib+bun run attw, and the fullbun run test:coverageover every file. I ran coverage for the changed component only; the required CI job runs the whole suite. Please approve the workflow run for this fork so CI can verify the rest.Test Environment
Checklist
bun run test:coverageandbun run coverage:check) — for the changed component; the whole-suite run is left to CIsrc/lib/db/providers/, I updated the matchingdocs/providers/documentation andtests/integration/db/tests in the same PR (provider triad) — not applicable, no provider touched