Conversation
Adds a Language section to the app settings listing the locales from the generated locale config, plus System default. Uses LocaleManager (minSdk is 33), so the choice is the same per-app language setting as in the system settings. It is shown regardless of connection/premium state. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Translates all strings. AirPods feature names follow Apple's official Korean terminology from the Korean AirPods User Guide (support.apple.com/ko-kr/guide/airpods), e.g. 대화 인지 (Conversation Awareness), 노이즈 캔슬링, 주변음 허용, 개인 맞춤형 음량, 자동으로 착용 감지. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
QuerTeal
marked this pull request as ready for review
September 27, 2026 15:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In-app language picker
generateLocaleConfig = true, read viaLocaleConfig).LocaleManager.setApplicationLocales()(minSdk is 33), so the choice is the same per-app language setting found in the system settings.hasConnectedToAACP/ premium block, so it is always reachable.values/:languageandsystem_default.Korean translation (
values-ko)values/and all of them match.Not covered: about 100 UI strings are hardcoded in Kotlin (e.g.
NoiseControlWidgetConfigurationActivity,HeartRateScreen,DebugScreen) and remain English. Moving them to resources could be a follow-up PR.Testing
assembleFossDebugbuilds._generated_res_locale_config.xmlnow includesko.values-kocovers every translatable key invalues/with matching format arguments.cmd locale get-app-locales→[]), so System default resolves tovalues-ko.🤖 Generated with Claude Code