Skip to content

android(fix): don't log proximity keys (IRK / encryption key) #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QuerTeal wants to merge 1 commit into
base: android/rewrite
Choose a base branch
from
Open

android(fix): don't log proximity keys (IRK / encryption key) #810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...src/main/kotlin/me/kavishdevar/librepods/bluetooth/aacp/packet/MagicKeysResponsePacket.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,12 @@ data class MagicKeyResponsePacket(
try {
keys[MagicKeyType.fromByte(keyType)] = key
} catch (e: Exception) {
Log.e(TAG, "incorrect key type received: $keyType, ${key.toHexString()}", e)
Log.e(TAG, "incorrect key type received: $keyType", e)
}
offset += keyLength
Log.d(TAG, "Parsed Proximity Key: Type: ${keyType}, Length: $keyLength, Key: ${key.toHexString()}")
// never log the key itself: the IRK/encryption key let anyone resolve and decrypt these AirPods' BLE
// advertisements, and logs end up in bug reports
Log.d(TAG, "Parsed Proximity Key: Type: ${keyType}, Length: $keyLength")
}

return MagicKeyResponsePacket(keys, payload)
Expand Down