Skip to content

fix(android): take over for untyped media and unknown AirPods state #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jeremy0538 wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −3
Open

fix(android): take over for untyped media and unknown AirPods state #820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22d3b82
android: count untyped media playback as music for takeover
Jeremy0538 Oct 1, 2026
e0ee116
android: follow the media setting when the AirPods state is unknown
Jeremy0538 Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions android/app/src/main/java/me/kavishdevar/librepods/services/AirPodsService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2571,14 +2571,19 @@ class AirPodsService : Service(), SharedPreferences.OnSharedPreferenceChangeList
return
}

val shouldTakeOver = when (bleManager.getMostRecentStatus()?.connectionState) {
val airPodsState = bleManager.getMostRecentStatus()?.connectionState
Log.d(TAG, "AirPods state for takeover: $airPodsState")
val shouldTakeOver = when (airPodsState) {
"Disconnected" -> config.takeoverWhenDisconnected
"Idle" -> config.takeoverWhenIdle
"Music" -> config.takeoverWhenMusic
"Call" -> config.takeoverWhenCall
"Ringing" -> config.takeoverWhenCall
"Hanging Up" -> config.takeoverWhenCall
else -> false
// The first advertisement after the AirPods reappear often carries a state byte that
// isn't mapped (or there is no status yet). Refusing then means the takeover only
// happens on the next media change, so follow the media setting instead.
else -> config.takeoverWhenMusic
}

if (!shouldTakeOver) {
Expand Down
11 changes: 10 additions & 1 deletion android/app/src/main/java/me/kavishdevar/librepods/utils/MediaController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,16 @@ object MediaController {

Log.d("MediaController", "Current active content types: $currentActiveContentTypes")

val hasNewMusicOrMovie = currentActiveContentTypes.any { contentType ->
// Some players (e.g. Poweramp over OpenSL ES) leave the content type unknown, so a
// USAGE_MEDIA stream with no content type counts as music too.
val hasUntypedMedia = configs?.any { config ->
config.audioAttributes?.let { attrs ->
attrs.usage == android.media.AudioAttributes.USAGE_MEDIA &&
attrs.contentType == android.media.AudioAttributes.CONTENT_TYPE_UNKNOWN
} ?: false
} ?: false

val hasNewMusicOrMovie = hasUntypedMedia || currentActiveContentTypes.any { contentType ->
contentType == android.media.AudioAttributes.CONTENT_TYPE_MUSIC ||
contentType == android.media.AudioAttributes.CONTENT_TYPE_MOVIE
}
Expand Down