Repository navigation
Conversation
This PR fixes the compilation errors introduced with updating to GameInput v4.
Collaborator
|
I'm continuing this work in #16590 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the compilation errors introduced with updating to GameInput v4.
I wasn't sure if it's okay to do it myself, so if there are any inconveniences, this PR can be closed!
I installed GameInput v4 from the NuGet package and tested this PR with
set SDL_JOYSTICK_DIRECTINPUT=0andset SDL_JOYSTICK_GAMEINPUT=1. This PR seems to work with DirectInput controllers I have, I can't test with DualShock 4 or Xbox One controllers at the moment because they're not with me at the moment.There were also changes to the GameInput video code that I haven't tested, and I'm not sure how to test them. 😅
TODO:
TODO for separate PRs:
Existing Issue(s)
None