Skip to content

Fix compilation errors with GameInput v4 - #16564

Closed
Nintorch wants to merge 4 commits into
libsdl-org:mainfrom
Nintorch:fix-gameinput-backend-compilation
Closed

Nintorch wants to merge 4 commits into
libsdl-org:mainfrom
Nintorch:fix-gameinput-backend-compilation

Conversation

@Nintorch

@Nintorch Nintorch commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor
  • I confirm that I am the author of this code and release it to the SDL project under the zlib license. This contribution does not contain code from other sources, including code generated by a Large Language Model ("AI").

Description

This PR fixes the compilation errors introduced with updating to GameInput v4.
I wasn't sure if it's okay to do it myself, so if there are any inconveniences, this PR can be closed!

I installed GameInput v4 from the NuGet package and tested this PR with set SDL_JOYSTICK_DIRECTINPUT=0 and set SDL_JOYSTICK_GAMEINPUT=1. This PR seems to work with DirectInput controllers I have, I can't test with DualShock 4 or Xbox One controllers at the moment because they're not with me at the moment.

There were also changes to the GameInput video code that I haven't tested, and I'm not sure how to test them. 😅

TODO:

  • Test with Xbox controllers (including the system buttons)
  • Test with PS controllers (including the system buttons)
  • Test with Nintendo Switch controllers? (including the system buttons)
  • Test the changes to the video code

TODO for separate PRs:

  • LED support
  • Touchpad support

Existing Issue(s)

None

@slouken

slouken commented Oct 25, 2026

Copy link
Copy Markdown
Collaborator

I'm continuing this work in #16590

@slouken slouken closed this Oct 25, 2026
@Nintorch
Nintorch deleted the fix-gameinput-backend-compilation branch October 25, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants