Repository navigation
fix: D3D12/METAL_INTERNAL_InitBlitResources not zero-initializing SDL_GPUSamplerCreateInfo - #16588
Closed
sleeptightAnsiC wants to merge 1 commit into
Closed
sleeptightAnsiC wants to merge 1 commit into
sleeptightAnsiC wants to merge 1 commit into
Conversation
…_GPUSamplerCreateInfo which was creating a non-zero invalid property ID, which isn't allowed by SDL Refs: libsdl-org#16583
Author
|
Yuck! I was 1min late... dedb925 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the problem mentioned in #16583 (comment), and similar one in D3D12 backend. See linked Issue for more info.
I grepped for all occurrences of
SDL_GPU[a-zA-Z_]*Infobut couldn't find any other place where this would be a problem. Sadly, I don't have any hardware to test the Metal backend.