Skip to content

[bug] first combo target can dispatch after request send-budget reservation is denied #5688

Closed

Description

@RHODIZSECURITY

Client or integration

Direct HTTP/API client

Area

Proxy and routing

Summary

On official v2.63.0, the first combo target can still dispatch after the shared request-send budget refuses its reservation. Expected: denied first-target reservation makes zero upstream inference requests and returns the existing typed local 429 request_send_budget_exhausted. For later targets, denial should preserve the last real upstream failure without dispatching the denied target.

Reproduction

  1. Configure a failover combo.
  2. Arrange for the shared request send budget to be exhausted before the first combo dispatch.
  3. Enter executeComboResponses.
  4. Observe that a denied first reservation can fall through into physical dispatch.
  5. Local regression coverage asserts first-target refusal => upstream hit count 0 and typed 429; later-target refusal => backup hit count 0 and prior upstream response preserved.

Version

2.63.0 / commit 96b1406

Operating system

Ubuntu Server Linux x86_64

Provider and model

Not provider-specific

Logs or error output

Expected local error code: request_send_budget_exhausted

Screenshots and supporting files

Related to PR #4609, which established the shared request-send budget. This report is the remaining combo first-target admission gap.

Redacted configuration

{"combo":{"strategy":"failover","targets":["provider-a/model-a","provider-b/model-b"]}}

Checks

  • I searched existing issues and documentation.
  • I removed secrets, tokens, account details, request credentials, and personal data.

Activity

  1. github-actions commented on Sep 23, 2026

    @github-actions
    Contributor

    Issue reopened

    The report now contains the information required by the automated check. Thanks for updating it.

  2. added
    bugSomething isn't working
    proxyHTTP proxy, routing, reverse-proxy / management auth
    on Sep 23, 2026
  3. lidge-jun commented on Sep 24, 2026

    @lidge-jun
    Owner

    Fixed on dev by bundle #5741 (squash-merged as 893c81c); it will ship in the next release. Closing manually because dev is not the default branch, so GitHub does not auto-close. If you still see this on a build that includes 893c81c, please reopen with the version and a redacted reproduction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingproxyHTTP proxy, routing, reverse-proxy / management auth

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions