Repository navigation
port(go): async Windows ACL harden for response-state (#645) #685
Description
Source
devmerge: fix(windows): async ACL harden for response-state writes (#612) #645 (341d4863, closes [Bug]: synchronous Windows ACL hardening stalls the proxy on response-state writes #612)dev2-gocarry: fix(windows): carry async ACL harden onto dig2-go (#645) #686
Gap
TS replaces sync icacls waits on the response-state write path with async ACL hardening (hardenSecretPathAsync / atomicWriteFileAsync), destination-path timeout memo, single-flight persistence, and awaited flush on shutdown (owner-first grant preserved).
Go has go/internal/platform/winacl_common.go and go/internal/server/responses_state*.go — needs parity for async ACL / write-path behavior.
Done when
Go response-state persistence matches the TS oracle with tests green on dev2-go.
Activity
github-actions commentedon Jul 29, 2026
Automated translation bookkeeping — detected language: unknown.
fix(windows): carry async ACL harden onto dig2-go (#645)
lidge-jun commentedon Jul 29, 2026
Closing: the
dev2-goGo native-port line is retired, so this port obligation no longer exists.The dual-track policy required every merge into
devto be rebased ontodev2-goand ported undergo/. That cost outran its return — the carry backlog never cleared and dogfooding the Go runtime kept producing new defects. Bun-native TypeScript ondevis the single runtime line again.The branch history is preserved read-only at https://github.com/lidge-jun/opencodex-go-archive, and its final tip stays reachable in this repository as the
archive/dev2-gotag. Theneeds-go-portlabel is retired.The TypeScript change this issue tracked is already on
dev; only the Go counterpart is dropped. Future native work is expected to be an incremental module ondev(Rust via N-API is the current candidate) rather than a second integration branch. SeeMAINTAINERS.mdfor the decision record.lidge-jun commentedon Jul 29, 2026
Closing this as not planned: the Go native-port line it belonged to has been retired.
What changed. We ran
dev(Bun-native TypeScript) anddev2-go(Go native port) as two integration lines, and every merge intodevcarried an obligation to port the same change ontodev2-go. In practice that dual track cost more than the port returned — dogfooding the Go runtime kept surfacing new defects faster than we closed them, and the carry queue never emptied. Sodevis once again the single integration line, and there is no port obligation attached to adevmerge any more.Nothing is lost. The full
dev2-gohistory is archived at lidge-jun/opencodex-go-archive, and the final tip is taggedarchive/dev2-goin this repository. If native code returns, the plan is an incremental module (for example Rust via N-API) landing ondev, not a second full-runtime branch.The underlying fix is already on
dev— this issue only tracked the missing Go counterpart, so there is no behavior regression from closing it. Theneeds-go-portlabel is retired as well.Sorry for the churn, and thank you for the carry and port work you put into this line. It was genuinely useful for learning where the runtime boundaries are; the direction change is on me, not on the work.
Wibias commentedon Jul 30, 2026
[shipping-github] Research review
Claim: Port the TS async Windows ACL harden for response-state onto the Go runtime (dev2-go).
Checked against: dev@be177ea5 (release/default: main)
dev); Go counterpart Not actionable afterdev2-goretirementEvidence: Issue closed by owner as NOT_PLANNED; Go line archived.
AGENTS.md/MAINTAINERS.md: Bun-native TS ondevis the single runtime line.Gaps: None for this tracker item.
Wibias commentedon Jul 31, 2026
[shipping-github] Full review
No open PR for this issue. Closed as NOT_PLANNED (Go port retired; TypeScript path already on
dev). Verdict: not-useful for a new PR.