fix(chatgpt): preserve launcher when app inspection fails

[lcxhh521]

Summary

• Keep failed app discovery or process inspection distinct from a confirmed absent/exited app. status reports unknown; launch and restore refuse to open when exit cannot be confirmed.
• Preflight process inspection before writing the launcher, and preserve it when discovery throws or restore cannot confirm exit. Keep the existing cleanup behavior for an actual not-installed result.
• Extend the existing isolated command fixture and document the boundary. A later inspection can still fail after an atomic launcher update; this is not an all-or-nothing restart transaction.
• This is a small original-Desktop lifecycle reliability change. It introduces no new UI, watcher, proxy settings, CA/intercept, credential handling or gate rewriting. It does not establish a complete replacement for feat(chatgpt-unblock): route an app that opened before opencodex #6381 or feat(chatgpt-unblock): PAC-fallback mode so traffic survives opencodex stopping #5947.

Verification

Base: daf323de262de0ef0098ec23d6551232320c9756.

Passed in an isolated Linux cloud worktree:

• Bun 1.4.3: bun test ./tests/clients/desktop-app-server-shim-launcher.test.ts --test-name-pattern 'restore validates': 30 pass, 18 intentionally filtered, 200 assertions. App discovery, process commands, signatures and config are mocked; launcher files are synthetic temporary files. Independent review reran the native focused suite successfully on Bun 1.4.2 before the final pinned 1.4.3 rerun.
• Bun 1.4.3: bun test ./tests/test-layout.test.ts ./tests/test-layout-tooling.test.ts: 19 pass, 0 fail.
• bun run typecheck, bun run structure:check, bun run privacy:scan, and git diff --check pass.
• Documentation: bun install --frozen-lockfile --ignore-scripts found dependencies unchanged; bun run build passed with a disposable HOME and telemetry disabled: 569 pages, 79,403 internal links checked.

Additional nonstandard strict typechecking of the two test files is blocked by the unchanged scripts/test-temp-lock.ts:78: its SyncSubprocess type has no signal property. Checking that unchanged script alone reproduces the same error. Production source typecheck passes; this extra test-type check is not reported as passing.

Not run: full suite/import-connected aggregate, real macOS app discovery/quit/open, actual Desktop session behavior, account or network probes. Validation was intentionally bounded to mocked command behavior and local static/documentation checks; this draft is not a release-readiness attestation.

Checklist

• Scope stays focused and avoids unrelated cleanup.
• Docs or release notes were updated when needed.
• Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. The focused independent review found no new blocking issue; real native platform behavior remains unverified.

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

• Required local validation passed; commands, results, and any full-suite exception are documented.

• I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).

• I resolved all correct Codex and CodeRabbit findings.

• My PR is ready for review.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

✅ Deterministic PR hygiene checks passed.

[github-actions]

⏳ DRAFT

• review readiness checklist open (0/4 boxes ticked).

What to do

• Tick all four boxes in the PR description once you're done (currently 0/4).

Review readiness checklist

• ⬜ Required local validation passed; commands, results, and any full-suite exception are documented.
• ⬜ I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
• ⬜ I resolved all correct Codex and CodeRabbit findings.
• ⬜ My PR is ready for review.

0/4 boxes ticked.

This PR stays in draft until every box above is ticked.

[lidge-jun]

Thanks @lcxhh521! This change landed on dev in #7065 (1edd55a), carried unchanged in its own commit with you credited in a Co-authored-by trailer. The fork PR never got the repository's main CI, so I carried it onto an upstream branch to run it. Closing this PR because the carry superseded it.