Repository navigation
Conversation
- Add an absolute TLS handshake deadline and common lifecycle cleanup - Preserve certificate verification and caller cancellation reasons - Cover timeout, abort, peer close and protocol errors with native fixtures - Document the deadline and register focused regression coverage
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Contributor
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
lidge-jun
added a commit
that referenced
this pull request
Oct 13, 2026
…7055, #7056, #6925) (#7065) * fix(chatgpt): preserve launcher when app inspection fails Carries #7055. Report unknown inspection state and refuse an unconfirmed restart. Co-authored-by: lcxhh <lcxhh521@gmail.com> * fix(proxy): bound SOCKS5 TLS handshake lifetime Carries #7056. Clear deadline and listeners on every TLS handshake exit while keeping certificate verification. Co-authored-by: lcxhh <lcxhh521@gmail.com> * docs: triage exceeded-retry-limit 429 errors Carries #6925. Align refresh release conditions and the resolved credit rediscovery reference with current dev. Co-authored-by: Howard-Jerry <197214646+Howard-Jerry@users.noreply.github.com> --------- Co-authored-by: JUN <243035832+lidge-jun@users.noreply.github.com> Co-authored-by: lcxhh <lcxhh521@gmail.com> Co-authored-by: Howard-Jerry <197214646+Howard-Jerry@users.noreply.github.com>
Owner
lidge-jun
added a commit
that referenced
this pull request
Oct 13, 2026
…top Bad credentials (#7053, #7054) (#7062) * fix(kiro): accept authorized social device grants Carries #7053. Preserve token, profile, principal, and HTTP validation. Co-authored-by: Veritas-7 <234569343+Veritas-7@users.noreply.github.com> * fix(kiro): quarantine exact desktop bad-credentials refusals Carries #7054. Keep AWS SSO and other status/message pairs retryable. Co-authored-by: Veritas-7 <234569343+Veritas-7@users.noreply.github.com> * fix(chatgpt): preserve launcher when app inspection fails Carries #7055. Report unknown inspection state and refuse an unconfirmed restart. Co-authored-by: lcxhh <lcxhh521@gmail.com> * fix(proxy): bound SOCKS5 TLS handshake lifetime Carries #7056. Clear deadline and listeners on every TLS handshake exit while keeping certificate verification. Co-authored-by: lcxhh <lcxhh521@gmail.com> * docs: triage exceeded-retry-limit 429 errors Carries #6925. Align refresh release conditions and the resolved credit rediscovery reference with current dev. Co-authored-by: Howard-Jerry <197214646+Howard-Jerry@users.noreply.github.com> --------- Co-authored-by: JUN <243035832+lidge-jun@users.noreply.github.com> Co-authored-by: Veritas-7 <234569343+Veritas-7@users.noreply.github.com> Co-authored-by: lcxhh <lcxhh521@gmail.com> Co-authored-by: Howard-Jerry <197214646+Howard-Jerry@users.noreply.github.com> Co-authored-by: jun <jun@juns-Mac-Studio.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a narrow shared-transport reliability fix. It does not change Desktop UI, account or quota admission, automatic readiness/fallback, certificate trust, or system proxy settings. It does not implement or close #6381 or #5947.
Verification
The publication preflight found
devtwo unrelated commits ahead at a29cb3d; none of the six changed paths differ, and this draft retains the exact tested base below.Validated on Linux with Bun 1.4.3 (c6da4a4d3), based on dev daf323d:
bun test tests/lib/socks5-tls-lifecycle.test.ts tests/lib/socks5-upload-lifecycle.test.ts tests/test-layout.test.ts: 16 passed, zero failures. Tests ran from the repository root with the normal preload and disposable test homes.node_modules/.bin/tsc --noEmit: passed.node_modules/.bin/tsc --ignoreConfig --noEmit --strict --skipLibCheck --target ESNext --module ESNext --moduleResolution bundler --types bun-types tests/lib/socks5-tls-lifecycle.test.ts: passed.bun scripts/privacy-scan.ts: passed.bun scripts/structure-ssot.ts: passed.git diff --check: passed.An expanded raw-transport run also passed both SOCKS null-body cases but failed three unchanged pinned-HTTP cases: a 204 first-byte timeout and 205/200 responses returning 502. The 204 and 200 failures reproduce on pristine current dev before applying this patch; the 205 failure reproduces on pristine dev20cd561, and its test and pinned transport are unchanged between those bases. The underlying baseline failure remains unresolved.
The full suite and broad import-graph suite were not run: this isolated validation is limited to reviewed synthetic/loopback transport fixtures, and the broader graph includes live-provider/account paths. Full
socks5-fetch.test.ts, cross-platform runs and CI remain outstanding. Focused results are not a full-suite or merge-readiness claim.Checklist
Keep this PR in draft pending maintainer/security review, required exact-head CI and completion of the repository's review-readiness checks. Certificate verification remains enabled; no authentication or proxy credential behavior is intentionally changed.
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.