Skip to content

test(codex): allow child generation diagnostics before outer timeout #7085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidge-jun merged 2 commits into from
Oct 15, 2026
Merged

test(codex): allow child generation diagnostics before outer timeout #7085

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd6e8d6
test(codex): allow child generation diagnostics before outer timeout
luvs01 Oct 14, 2026
03e80b9
Merge remote-tracking branch 'origin/dev' into pr-7085-work
Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/codex-integration/codex-config-generation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ import { repoPath, repoRoot } from "../helpers/repo-root";
import { captureStartupChildOutput, STARTUP_OUTPUT_TAIL_CHARS } from "../helpers/startup-child-output";

const CHILD_TIMEOUT_MS = 10_000;
// Allow both child phases and cleanup to finish before Bun aborts the test.
const CHILD_TEST_TIMEOUT_MS = 3 * CHILD_TIMEOUT_MS;
const configModuleUrl = pathToFileURL(repoPath("src/config.ts")).href;
const generationGuardRaceScript = `
import { existsSync, writeFileSync } from "node:fs";
Expand Down Expand Up @@ -353,7 +355,7 @@ test("two real processes racing one generation run exactly one callback", async
generation: { value: 0 },
});
} finally { await stopGuardRaceChildren(children); }
});
}, CHILD_TEST_TIMEOUT_MS);

test("generation-race readiness reports a child's early exit and stderr", async () => {
const readyPath = join(testRoot, "exited.ready");
Expand All @@ -366,7 +368,7 @@ test("generation-race readiness reports a child's early exit and stderr", async
expect(guardRaceDiagnostics([child])).toContain("fixture generation startup error");
expect(child.process.exitCode).toBe(7);
} finally { await stopGuardRaceChildren([child]); }
});
}, CHILD_TEST_TIMEOUT_MS);

test("generation-race diagnostics drain both pipes with bounded tails", async () => {
const readyPath = join(testRoot, "output.ready");
Expand All @@ -385,7 +387,7 @@ test("generation-race diagnostics drain both pipes with bounded tails", async ()
expect(output.stdout.tail).toEndWith("stdout-tail");
expect(output.stderr.tail).toEndWith("stderr-tail");
} finally { await stopGuardRaceChildren([child]); }
});
}, CHILD_TEST_TIMEOUT_MS);

test("generation-race cleanup reaps a child still waiting after readiness", async () => {
const readyPath = join(testRoot, "held.ready");
Expand All @@ -396,7 +398,7 @@ test("generation-race cleanup reaps a child still waiting after readiness", asyn
try { await waitForPaths([readyPath], [child]); }
finally { await stopGuardRaceChildren([child]); }
expect(child.process.exitCode !== null || child.process.signalCode !== null).toBe(true);
});
}, CHILD_TEST_TIMEOUT_MS);

test("a throwing guard callback rolls back and releases the transaction", () => {
expect(() => withExpectedConfigGenerationSync({ value: 0 }, () => {
Expand Down
Loading