Skip to content

feat(antigravity): show account membership tier badge (carry #5932) - #7157

Merged
lidge-jun merged 2 commits into
devfrom
carry/5932-account-plan-badge
Oct 15, 2026
Merged

lidge-jun merged 2 commits into
devfrom
carry/5932-account-plan-badge

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Display the Google Antigravity account's canonical membership tier ID beside its label and in the account button's accessible name. Unknown plans render no badge; pause, resume, reauthentication and active-account behavior are preserved.
  • Carry the missing UI portion of feat(antigravity): expose membership plan in account UI #5932 by @juzijia (source head 9b6e14d359cebb1c3fdd016bcc11384c9b2b45bc) onto dev 7640a942b35044c974e534b84d5a8049f4a8ae9a. fix(accounts): admit reset Anthropic accounts and report OAuth subscription plans (supersedes #6933) #6953 already supplies plan persistence and account-summary projection, so this carry changes no OAuth parser, token store, or API behavior.
  • Render canonical IDs such as free-tier, gemini-pro, gemini-ultra, and standard-tier literally in every locale; avoid guessing marketing names from those IDs. Update user documentation and the GUI contract.

Co-authored-by: cubebox 58514883+juzijia@users.noreply.github.com

Verification

Every local test/proxy used isolated temporary OPENCODEX_HOME and CODEX_HOME; the screenshot proxy ran on port 24392 with fabricated account credentials and plan gemini-pro.

  • OPENCODEX_HOME=$(mktemp -d) CODEX_HOME=$(mktemp -d) bun test ./gui/tests/provider-quota-refresh-controls.test.tsx — 13 pass, 0 fail, 79 assertions. Covers four canonical IDs in Chinese, accessible names, absent plans, active state, pause/resume/reauth callbacks and pending controls. The original file on untouched dev passed 12 tests; the new badge test against the original component failed as expected (0 pass, 1 fail).
  • OPENCODEX_HOME=$(mktemp -d) CODEX_HOME=$(mktemp -d) bun run typecheck — exit 0.
  • From gui/, OPENCODEX_HOME=$(mktemp -d) CODEX_HOME=$(mktemp -d) bun run lint and bun run lint:i18n with the same isolation — exit 0 each.
  • OPENCODEX_HOME=$(mktemp -d) CODEX_HOME=$(mktemp -d) bun run build:gui — exit 0 for before and after builds, including GUI TypeScript. Existing bundle-size warning remains.
  • From docs-site/, bun install --frozen-lockfile then isolated bun run build — exit 0; 577 pages built, 81,200 internal links checked.
  • Isolated bun run structure:check, bun run privacy:scan, bun scripts/file-size-ratchet.ts, and git diff --check origin/dev...HEAD — exit 0 each.
  • OPENCODEX_HOME=$(mktemp -d) CODEX_HOME=$(mktemp -d) node /tmp/shot-carry-5932/smoke.mjs — built-GUI browser checks at 1440px and 390px: badge, accessible name/current state, enabled Pause control and no document horizontal overflow.
  • Full local suite omitted because other triage worktrees are testing concurrently. Independent review rerun at the same head with temporary homes and OCX_TEST_NO_QUEUE=1: bun run test:changed ran to completion, selected 0 tests (the diff is GUI/CSS/docs/structure only, outside the root import graph), and exited 1 by its zero-selection guard. Those file-as-data dependents were run explicitly instead: bun test over the 21 gui/tests files that reference the changed GUI files — 239 pass, 0 fail; bun test over tests/gui/provider-workspace-auth.test.ts, the three tests/ci-workflows/docs-provider-* docs tests, structure-ssot, file-size-ratchet and test-layout — 206 pass, 0 fail. typecheck, GUI lint/lint:i18n, privacy:scan, structure:check and build:gui exited 0 on the review rerun.

Before: unmodified origin/dev build with the seeded account.

Before: sandbox Antigravity account without plan badge

After: carry build with the same fixture and the gemini-pro badge.

After: sandbox Antigravity account with canonical plan badge

Screenshots use real production GUI builds and playwright-core installed only in external scratch space. /Applications/Google Chrome.app stalled before initialization on this machine; the captures use the installed Google Chrome Headless Shell 154.0.8037.92 through Playwright's executablePath instead. Images are committed only on pr-assets.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. Display-only UI diff; authentication, credentials, workflows and dependencies are unchanged.

Full cross-platform CI: workflow_dispatch run 38713772584, head 7be3dda764dfee6b9e3a6f1fb49d9c593020207e, branch carry/5932-account-plan-badge; queued when handed off. The original #5932 is closed with a link to this credited carry. No merge was performed.

Summary by CodeRabbit

  • New Features
    • Google Antigravity account rows now show the account’s membership tier as a badge when available. The tier is also included in the account’s accessible label; unknown tiers are omitted.
  • Documentation
    • Updated provider and API guidance to describe the tier badge and clarify that it does not change routing, quota, or account controls.

…5932)

Carry only the missing account-row badge and accessibility from #5932 at 9b6e14d; plan persistence and projection already landed in #6953.

Co-authored-by: cubebox <58514883+juzijia@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 3d6d9dc7-f815-464c-a206-f11bb02ab0db
📥 Commits

Reviewing files that changed from the base of the PR and between 7be3dda and 3bf5e95.

📒 Files selected for processing: 1
  • structure/gui-and-management-api.md
+-----------------------------------------------+
| Edge cases are just center cases in disguise. |
+-----------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 1bb12fd4-6889-47b6-871b-c2d0efe48420
📥 Commits

Reviewing files that changed from the base of the PR and between 7640a94 and 7be3dda.

📒 Files selected for processing: 7
  • docs-site/src/content/docs/guides/providers.md
  • gui/src/components/provider-workspace/ProviderAuthPanel.tsx
  • gui/src/components/provider-workspace/types.ts
  • gui/src/hooks/useProviderAccountPools.ts
  • gui/src/styles/provider-workspace-settings.css
  • gui/tests/provider-quota-refresh-controls.test.tsx
  • structure/gui-and-management-api.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

📝 Walkthrough

Google Antigravity account rows now show a known plan as a badge and include it in the accessible name. The plan is optional. Other providers’ rows remain unchanged. Tests and documentation cover plan display and account controls.

Changes: Antigravity plan display

Layer / File(s) Summary
Plan data and account-row display
gui/src/hooks/useProviderAccountPools.ts, gui/src/components/provider-workspace/types.ts, gui/src/components/provider-workspace/ProviderAuthPanel.tsx, gui/src/styles/provider-workspace-settings.css, gui/tests/provider-quota-refresh-controls.test.tsx, docs-site/src/content/docs/guides/providers.md, structure/gui-and-management-api.md
The account types add an optional nullable plan. Google Antigravity rows display a present plan as a badge and include it in the accessible name. Tests cover plan states and account controls. Documentation describes the badge and its behavior.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 7be3d

The tier badge and accessible name receive the account’s plan, while accounts without a plan remain covered by the rendering test. No actionable merge risk remains after normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. (3 skipped: 3 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: adding a membership tier badge for Google Antigravity accounts. The scope matches the documented UI and accessibility updates.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. (3 skipped: 3 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lidge-jun
lidge-jun marked this pull request as ready for review October 15, 2026 09:36
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner October 15, 2026 09:36
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T09:45:37.984971Z 7be3dda Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the enhancement New feature or request label Oct 15, 2026
@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer integration into dev (MAINTAINERS.md dev maintainer-integration policy; batch integration authorized by @lidge-jun on 2026-10-15).

  • Head: 3bf5e956724b06fda204c4671ff9b19b7ceba203 (tree c418512965c40b11002a5a10c19c94fd6e0d5278) = this branch merged with origin/dev 113ededdb2.
  • Exact-head evidence: GitHub-hosted Actions for this account have not been assigning runners since 2026-10-15 13:30 UTC, so by owner decision the evidence is a full bun run test (Bun 1.4.3 test runner, root and GUI dependencies installed, GUI built) of this exact tree on a maintainer host (Linux x86_64): exit 1, 7 min, 31 failing test(s), each also failing in the same host's baseline run of dev 60bf4c7 (environment-only): Codex shim install readiness > a refused install exits unsuccessfully and preserves its re, Codex shim install readiness > keeps install advisory when the Codex config cannot be read, Codex shim install readiness > the install command surfaces readiness warnings without lea, GUI pairing client > sends one bodyless origin-bound capability and redacts rejected bodie, Node launcher PATH fallback activation > broken bundle reaches validated PATH Bun, Node launcher PATH fallback activation > inspection bundle reaches validated PATH Bun, Node launcher PATH fallback activation > missing bundle reaches validated PATH Bun, a secondary ensure parent preserves shared Grok, Codex and Claude agent bytes, ….
  • Local gates on the same tree: bun run typecheck, file-size ratchet, test-layout and structure:check.
  • Hosted CI checks for this head may still be queued; they are not claimed as evidence.

@lidge-jun
lidge-jun merged commit d9ef862 into dev Oct 15, 2026
3 checks passed
@lidge-jun
lidge-jun deleted the carry/5932-account-plan-badge branch October 15, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant