[gvladika]

Which Linear task belongs to this PR?

Fixes EXSC-1286

Why did I implement it this way?

Removes .github/workflows/convertForkedPRsToInternal.yml instead of fixing its YAML. The file has been unparseable since #1212, so it never ran: all 919 recorded runs (893 push, 26 pull_request) are 0-second parse failures, and no fork-pr-* branch exists. Fork PRs are already converted by hand (#2604 → #2607, #2605 → #2609), and nothing in the repo references the workflow. Making it valid would enable a pull_request_target job that checks out fork code and pushes it to origin with GIT_ACTIONS_BOT_PAT_CLASSIC on every fork PR, which is a riskier pattern than the manual process it would replace. Deleting it also stops the failed run recorded on every push.

Checklist before requesting a review

• I have performed a self-review of my code
• This pull request is as small as possible and only tackles one problem
• I have added tests that cover the functionality / test the bug
• For new facets: I have checked all points from this list: https://www.notion.so/lifi/New-Facet-Contract-Checklist-157f0ff14ac78095a2b8f999d655622e
• I have updated any required documentation

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

• I have checked that any arbitrary calls to external contracts are validated and or restricted
• I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
• I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 14 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: ac112bbe-5722-4dec-b6e2-a7d20696aa85

Commits

Reviewing files that changed from the base of the PR and between b0f61b0 and c4214eb.

Files selected for processing: 1

• .github/workflows/convertForkedPRsToInternal.yml

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[lifi-qa-agent]

🔍 QA Review — EXSC-1286 · PR #2617 (🆕 First review, head 77ce583)

Verdict: ✅ Approve — 0 findings · Awaiting response: 0

PR deletes .github/workflows/convertForkedPRsToInternal.yml (−139 lines, 1 file). This matches the ticket's decision to delete rather than fix the workflow.

What was verified

• The file is the only change; nothing is added.
• No file in lifinance/contracts references convertForkedPRsToInternal (code search returned nothing), so no other workflow, doc or required check depends on it.
• Deleting it removes the pull_request_target plus write-PAT push pattern the ticket warns about; it does not weaken any governance or signing gate.
• CI: no failing checks on the head.

Notes

• 🔵 EXSC-1286 says fork PRs are converted by hand; a short pointer in the contributor docs would help, but it is out of scope here.

Downstream impact

CI workflow only; AuditNotRequired and trivial labels are correct.

[lifi-qa-agent]

🤖 [Automated QA Review] Approved — PR #2617: the unreferenced, never-run convertForkedPRsToInternal workflow is removed as the ticket decided

[thesems]

LGTM. Removing the unparseable workflow is reasonable, and there are no remaining repository references to it. No blocking findings.