Show backend settle time for trusted receives#79
Merged
Conversation
A trusted receive is timestamped from the per-payment time the backend reports, but the rebalancer also records discovery-time metadata with SystemTime::now() the first time it observes a payment. list_transactions preferred that metadata time whenever it existed, so with rebalancing on the backend's settle time was always discarded. For a payment that settled while the wallet was offline, the discovery stamp is the next launch rather than the real settle time. Since history is sorted by timestamp, such a receive also floated to the top as if it were brand new. Prefer the backend's settle time for inbound receives, falling back to the metadata time only for outbound sends, which we always observe as they happen. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A trusted receive is timestamped from the per-payment time the backend reports, but the rebalancer also records discovery-time metadata with SystemTime::now() the first time it observes a payment. list_transactions preferred that metadata time whenever it existed, so with rebalancing on the backend's settle time was always discarded.
For a payment that settled while the wallet was offline, the discovery stamp is the next launch rather than the real settle time. Since history is sorted by timestamp, such a receive also floated to the top as if it were brand new.
Prefer the backend's settle time for inbound receives, falling back to the metadata time only for outbound sends, which we always observe as they happen.