Drop BufReader in Deserialization of Consensus Objects#4743
Conversation
The BufReader wrapping is no longer needed after the rust-bitcoin `0.32.4` release which contains the standardisation of the trait bounds for deserialization to `Read` instead of `BufReader`.
Post `0.32.4` deserialization of consensus objects now use `Read` as the trait bounds, making the BufReader no longer needed for deserialization.
|
I've assigned @valentinewallace as a reviewer! |
|
The PR is small and surgical. Let me verify the change preserves the original "don't over-read" property and that the dependency supports the new API. The Cargo.toml already requires No issues found. |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
ad132ea
into
lightningdevkit:main
The rust-bitcoin
0.32.4release include the standardisation of deserialization methods to useReadoverBufReadwhen decoding/deserializing consensus objects, this makes the bufferedReadwrapper no longer needed and can now be dropped.BufReaderinReadableimpl.Readwrapper.