Skip to content

Pin zeroize for old Rust CI#4745

Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
joostjager:fix-zeroize-msrv-pin
Jun 24, 2026
Merged

Pin zeroize for old Rust CI#4745
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
joostjager:fix-zeroize-msrv-pin

Conversation

@joostjager

Copy link
Copy Markdown
Contributor

zeroize 1.9.0 uses Rust 2024 metadata, which Cargo 1.75 cannot parse. Pin it to 1.8.2 for older toolchains so the transaction sync HTTPS feature check keeps passing on the MSRV job.

zeroize 1.9.0 uses Rust 2024 metadata, which Cargo 1.75 cannot
parse. Pin it to 1.8.2 for older toolchains so the transaction sync
HTTPS feature check keeps passing on the MSRV job.
@ldk-reviews-bot

ldk-reviews-bot commented Jun 24, 2026

Copy link
Copy Markdown

I've assigned @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-claude-review-bot

Copy link
Copy Markdown
Collaborator

This is a trivial, correct CI dependency pin that mirrors the existing hyper-rustls pattern directly above it (same -lt 85 threshold, same cargo update --precise form). The comment accurately describes the cause and the change is consistent with surrounding code. I verified there's no conflicting zeroize pin elsewhere.

No issues found.

@valentinewallace valentinewallace left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy

@ldk-reviews-bot ldk-reviews-bot requested a review from tankyleo June 24, 2026 17:37
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.93%. Comparing base (6ac2cf3) to head (a8a4767).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4745   +/-   ##
=======================================
  Coverage   86.92%   86.93%           
=======================================
  Files         161      161           
  Lines      111661   111669    +8     
  Branches   111661   111669    +8     
=======================================
+ Hits        97065    97079   +14     
+ Misses      12088    12082    -6     
  Partials     2508     2508           
Flag Coverage Δ
fuzzing-fake-hashes 8.45% <ø> (-0.01%) ⬇️
fuzzing-real-hashes 32.41% <ø> (-0.01%) ⬇️
tests 86.26% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheBlueMatt TheBlueMatt merged commit 9df5c9d into lightningdevkit:main Jun 24, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants