Repository navigation
Conversation
LaurenzV
approved these changes
Oct 10, 2026
Comment on lines
+1485
to
+1487
| fontdb.with_face_data(font.id, |font_data, face_index| { | ||
| harfrust::Font::new(font_data.to_vec(), face_index) | ||
| })? |
Collaborator
There was a problem hiding this comment.
Could we please add a TODO that we need to add a ID -> Font data cache in resvg so we don't reclone such fonts for every text span?
I think not having this will likely block the next release.
| "proc-macro2", | ||
| "quote", | ||
| "syn", | ||
| "syn 2.0.119", |
Collaborator
There was a problem hiding this comment.
Can we please bump bytemuck accordingly so we don't have two syn versions in the tree?
… TODO Bumping bytemuck_derive to 1.12.1 moves it to syn 3, so only one syn version remains in the dependency tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Contributions: Code changes generated with Devin.
harfrust 0.14 requires owned font data (read-fonts'
Fontmodel), so the face data is shared from fontdb when it is aSource::Binaryand copied otherwise (e.g. file-backed system fonts).