Repository navigation
Conversation
A style element's text was only its first text node, so rules after an XML comment inside it were ignored, and a sheet starting with a comment was ignored whole. Browsers read all of its text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug was found with AI while working on an svg Tool. Everything is carefully checked by me, the description is written by me. Code and test has been created with Claude.
This PR fixes the following bug:
text t in <style> after an XML comment is ignored, but browsers are reading this text
The Fix: All text nodes of the style elements are readed, instead of only the first one -> node.text() .
Tested with the new test: structure/style/comment-between-rules
Where we found it: Maps from Wikipedia, only in 3 of 188, because we used them as test files.