Repository navigation
Fix marker viewport clipping with preserveAspectRatio - #1163
Merged
LaurenzV merged 3 commits intoOct 17, 2026
Merged
Conversation
LaurenzV
force-pushed
the
fix-marker-viewport-clip
branch
from
October 17, 2026 06:33
825dfcd to
4241c50
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markers with a viewBox whose aspect ratio differs from the marker viewport are clipped to the viewBox, cropping valid artwork with meet and allowing artwork outside the viewport with slice.
Transform the marker viewport rectangle into content coordinates before constructing its clip path, so clipping follows the viewport for meet, slice, alignment, and stroke-width scaling. A new pixel regression checks these cases at 1x and 2x scale, and the existing marker golden is updated after comparison with Chrome; the full workspace tests, formatting, copyright check, and no-default-feature checks pass.
Download the SVG reproducer