Repository navigation
Resolve paint servers in masks, patterns and feImage before caching - #1164
Merged
LaurenzV merged 2 commits intoOct 17, 2026
Merged
Conversation
LaurenzV
force-pushed
the
fix-feimage-shared-paint
branch
from
October 17, 2026 08:14
3461506 to
ad4286b
Compare
LaurenzV
changed the title
feImage before caching
Collaborator
|
Thanks, I've generalized this so it also fixes masks and patterns, which had the same issue. |
LaurenzV
force-pushed
the
fix-feimage-shared-paint
branch
from
October 17, 2026 08:18
ad4286b to
af618b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusing a user-space filter containing feImage can leave object-bounding-box gradients unresolved, producing a flat fill instead of the intended gradient.
Resolve paint servers in the referenced image subtree after its bounds are calculated and before the filter enters the shared cache, because the final tree pass cannot mutate a filter with multiple Arc owners. The regression compares two filtered instances with an unfiltered use of the same source and fails on main; the fixed output matches Chrome within one channel value, and the full workspace tests pass.
Download the SVG reproducer