fix: JSON-RPC error:null + omit empty params (BTC-family / Stellar) - #23
Closed
snowkide wants to merge 1 commit into
Closed
fix: JSON-RPC error:null + omit empty params (BTC-family / Stellar)#23snowkide wants to merge 1 commit into
snowkide wants to merge 1 commit into
Conversation
Bitcoin-family nodes emit "error": null on success; ParseError("null")
was inventing a server-side exception and exhausting upstreams
(dogecoin/litecoin/mutiny via erpc).
Omit empty params on the wire so Stellar (and similar) accept
getHealth/getLatestLedger — they reject "params":[].
Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
Author
|
Superseded by combined PR #24 (rebased onto |
Author
|
Closing in favor of #24. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"error": nullas success (Bitcoin Core / dogecoind / litecoind).paramswhen remarsaling outbound requests (Stellar rejectsparams:[]).Stacked on
feat/jsonrpc-architecture.Test plan
jsonrpc-passthrough-4; smoke doge-testnet + stellar + BTC-familyMade with Cursor