fix: treat no-op SSA apply as cache-sync success - #1
Merged
Conversation
Re-applying an unchanged ValidatingAdmissionPolicy left resourceVersion the same, so blockApply waited 2s for a newer RV and killed the leader. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the resourceVersion catch-up wait for real applies. If the poll expires and the object is still there, Apply already succeeded. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blockApplyrequired a newer resourceVersion after server-side apply. A no-op apply (existingvcluster-protected-apiservices) never changes RV, so the 2s poll returnedcontext deadline exceededand the controller leader exited.Test plan
go test ./pkg/util/blockingcacheclient/ghcr.io/linkpoolio/vcluster:feat-node-name-rewriting-v0.37-578c583c7on vcluster-test, then kick the leader and confirm it stays ReadyMade with Cursor