Repository navigation
4.0 server tests: remove RPLY14 - #9
Merged
Merged
Conversation
RPLY14 sends a CREATE, then resends it twice with the same XID on the same TCP connection and expects NFS4_OK each time. The other RPLY tests exercise the per-state-owner reply cache that RFC 7530 Section 9.1.7 requires, or replay an idempotent LOOKUP. RPLY14 alone depends on an XID-based duplicate request cache, which RFC 7530 does not specify. Section 3.1.1 also forbids an NFSv4.0 client from retrying a request unless the transport connection has been broken. A recent NFSD change drops a retransmission that arrives on the connection that carried the original request, so RPLY14 now fails against NFSD. Reconnecting before the replay does not rescue the test. NFSD may evict a DRC entry once the client has acknowledged the cached reply, so the replayed CREATE executes a second time and fails with NFS4ERR_EXIST. Remove RPLY14 and record its code as retired. Signed-off-by: Chuck Lever <cel@kernel.org>
jtlayton
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RPLY14 depends on an XID-based duplicate request cache that RFC 7530
does not specify. The test now fails against NFSD. Removing it leaves
the reply-cache tests that RFC 7530 Section 9.1.7 requires.