revert: "fix: correct dock context menu popup positioning"#1648
Merged
deepin-bot[bot] merged 1 commit intoJun 24, 2026
Merged
Conversation
This reverts commit b236970. 引入 popup 窗口菜单后,popup 会主动夺取输入焦点,导致 dock 右键 一级菜单与展开后的二级菜单之间出现互抢焦点的问题:二级菜单弹出 时会从一级菜单抢走焦点,进而触发一级菜单异常关闭或交互错乱。 先回退至 Qt.labs.platform 菜单方案,待焦点抢夺问题彻底解决后再 重新引入 DTK popup window 菜单。 Log: revert popup menu due to focus stealing between primary and submenu
There was a problem hiding this comment.
Sorry @yixinshark, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
mhduiy
approved these changes
Jun 24, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b236970.
原因
引入 DTK popup window 菜单后,popup 窗口会主动夺取输入焦点,导致 dock 右键菜单出现 一级菜单与二级菜单互抢焦点 的问题:
处理方案
先回退至原先的
Qt.labs.platform菜单方案,恢复稳定的菜单交互行为。待焦点抢夺问题彻底定位并修复后,再重新引入 DTK popup window 菜单(含PopupHandle模糊效果)。影响文件
panels/dock/MenuHelper.qmlpanels/dock/package/main.qmlpanels/dock/taskmanager/package/AppItem.qmldebian/control(回退libdtk6declarative (>> 6.7.44)版本约束)验证