test: add autotests Google Test framework + core/common-module unit tests - #512
Open
add-uos wants to merge 2 commits into
Open
test: add autotests Google Test framework + core/common-module unit tests#512add-uos wants to merge 2 commits into
add-uos wants to merge 2 commits into
Conversation
Introduce a standalone autotests/ test suite (Google Test + gmock, lcov coverage) for deepin-editor and cover the common module's core classes. Batch 1 classes (all done, 0 failed, 0 skipped): - Utils, Config, PerformanceMonitor, Eventlogutils, TextFileSaver, FileLoadThread, CSyntaxHighlighter, UrlInfo Batch statistics: - Total target classes: 8 - Passed: 8 - Failed: 0 - Skipped: 0 - Google Test cases: 68 (all passing, QT_QPA_PLATFORM=offscreen) - Function coverage (lcov, */src/*): 6.3% (76/1199) -- baseline Framework: - autotests/CMakeLists.txt: standalone project; compiles app sources into a single deepin-editor-autotest executable (deepin-editor has no lib target), per-class test files under autotests/<module>/test_*.cpp. - 3rdparty/stub/: built-in stub-ext (no network download). - run-ut.sh: configure + build + run + lcov + report, sources an optional ~/ut-deps user-local -dev prefix for headless/CI reproducibility. - report_generator/: HTML/CSV report emitter. Baseline commit: - eba9ef7 - test: fix 11 failing unit tests for deepin-editor (Qt6/TextFileSaver refactor) - 2026-08-07
Cover the QPlainTextEdit-based editor undo/redo command classes with round-trip redo/undo tests, and switch the test harness main() to QApplication so QWidget-based tests (QPlainTextEdit) run headless. Batch 2 classes (all done, 0 failed, 0 skipped): - DeleteTextUndoCommand2, MidButtonInsertTextUndoCommand, DragInsertTextUndoCommand Batch statistics: - Total target classes: 3 - Passed: 3 - Failed: 0 - Skipped: 0 - Google Test cases added: 4 (72 total, all passing) - Function coverage (lcov, */src/*): 7.1% (85/1199) Baseline commit: - eba9ef7 - test: fix 11 failing unit tests for deepin-editor (Qt6/TextFileSaver refactor) - 2026-08-07
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @add-uos, your pull request is larger than the review limit of 150000 diff characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideAdds a standalone Google Test-based autotest framework for deepin-editor, including build scaffolding, a local stub library, a rich HTML/CSV report generator pipeline, and an initial batch of unit tests for core common/editor modules, all without modifying production source code. Flow diagram for the new run-ut.sh unit test pipelineflowchart TD
A[run-ut.sh] --> B{from_step <= 1?}
B -->|yes| C[step_1_prepare_build_env]
C --> D[step_2_configure_cmake]
D --> E[step_3_compile_tests]
E --> F[step_4_run_tests<br/>ctest, test_output.log, test_results.xml]
F --> G[step_5_generate_coverage<br/>lcov, genhtml]
G --> H[step_6_generate_test_report<br/>python3 generate-report.py]
B -->|no, from_step=4| F
B -->|no, from_step=5| G
B -->|no, from_step=6| H
H --> I[test_report.html]
H --> J[test_data.json]
G --> K[coverage/html/index.html]
subgraph BuildDir[build-autotests]
C
D
E
F
G
end
subgraph Reports[test-reports]
F
G
H
I
J
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review★ 总体评分：60分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 # autotests/report_generator/generators/html_generator.py
import html # 新增导入
# 在 _generate_failed_tests_html 函数中修复 XSS
# 修改前:
# <pre class="text-danger mb-0" style="font-size: 0.85em; white-space: pre-wrap;">{formatted_msg}</pre>
# 修改后:
formatted_msg = fail_detail.get("formatted", "断言失败")
escaped_msg = html.escape(formatted_msg) # 转义HTML实体
failed_tests_html += f"""
<div class="mb-2">
<div class="alert alert-light p-2">
<small class="text-muted">{fail_detail['type'].replace('_', ' ').title()}</small>
<pre class="text-danger mb-0" style="font-size: 0.85em; white-space: pre-wrap;">{escaped_msg}</pre>
</div>
</div>
"""
# 在 _generate_coverage_modules_html 函数中修复 XSS
# 修改前:
# <h6 class="mb-0 module-name">{module["name"]}</h6>
# <span class="file-name">{file_name_html}</span>
# 修改后:
html += f"""
<div class="module-card card mb-3" id="module-{module_id}">
<div class="card-header d-flex justify-content-between align-items-center">
<div class="d-flex align-items-center">
<span class="module-icon me-2">{module_icon}</span>
<h6 class="mb-0 module-name">{html.escape(module["name"])}</h6>
<span class="badge ms-2 text-muted">{len(module["files"])} 文件</span>
</div>
...
file_name_html = html.escape(file_info['name']) # 确保基础文件名被转义
if file_info.get('coverage_html_path') and os.path.exists(file_info['coverage_html_path']):
file_name_html = f'<a href="file://{file_info["coverage_html_path"]}" target="_blank" class="file-link coverage-primary">{html.escape(file_info["name"])}</a>'// autotests/3rdparty/stub/addr_any.h
// 在 get_lib_pathname_and_baseaddr 函数中修复正则编译未校验问题
bool get_lib_pathname_and_baseaddr(std::string pathname_regex_str, std::string& name, unsigned long& addr)
{
// ... 前置代码 ...
regex_t pathname_regex;
// 修复：增加 regcomp 返回值检查
int ret = regcomp(&pathname_regex, pathname_regex_str.c_str(), 0);
if (ret != 0) {
return false;
}
if(NULL == (fp = fopen("/proc/self/maps", "r")))
{
regfree(&pathname_regex); // 修复：出错时释放正则对象
return false;
}
// ... 后续代码 ...
// 注意：在所有 return false 之前需要调用 regfree(&pathname_regex) 防止内存泄漏
} |
|
@add-uos: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deepin-editor 单元测试（autotests/）—— 自动生成首轮
为 deepin-editor 新增独立的
autotests/Google Test 测试套件（lcov 覆盖率），首轮覆盖核心模块。框架
autotests/CMakeLists.txt：独立 CMake 项目；deepin-editor 无库目标，故将应用源码直接编译进单个deepin-editor-autotest可执行文件，按类组织autotests/<module>/test_<class>.cpp。3rdparty/stub/：内置 stub-ext（不从网络下载）。run-ut.sh：配置 + 编译 + 运行 + lcov + 报告，自动加载可选的~/ut-deps用户级 -dev 前缀以支持无头/CI 复现。report_generator/：HTML/CSV 报告生成器。首轮覆盖类（全部通过，0 失败 / 0 跳过）
common：
Utils、Config、PerformanceMonitor、Eventlogutils、TextFileSaver、FileLoadThread、CSyntaxHighlighter、UrlInfoeditor：
DeleteTextUndoCommand2、MidButtonInsertTextUndoCommand、DragInsertTextUndoCommand结果
QT_QPA_PLATFORM=offscreen）*/src/*）：7.1%（85/1199）——首轮基线复现
./autotests/run-ut.sh # 报告：build-autotests/test-reports/test_report.html、build-autotests/coverage/html/index.html说明
eba9ef7c（test: fix 11 failing unit tests ...）。Summary by Sourcery
Add a standalone Google Test-based autotest framework, including build scripts, stubbing infrastructure, and HTML/CSV reporting, to cover core/common deepin-editor modules and establish a coverage-measured testing baseline.
New Features:
Build:
Tests:
Chores: