feat(accessibility): add AT-SPI accessible names to UI controls - #516
feat(accessibility): add AT-SPI accessible names to UI controls#516re2zero wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: re2zero The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideAdds AT-SPI-facing accessible names and object names to key editor UI components (menus, buttons, bars, dialogs, and panels), plus updates copyright years and introduces an expected-names YAML used for accessibility validation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
15e33be to
610c6bd
Compare
PR 验证结果验证摘要
✅ 代码审查代码修改清晰规范:
✅ 编译验证
|
610c6bd to
0f1b8f0
Compare
0f1b8f0 to
06e7ef7
Compare
Add setAccessibleName and setObjectName for all interactive UI controls and assertion-required elements across the editor: - Titlebar menu actions and window buttons - Find/Replace/JumpLine floating bars - Tab bar, context menus, and editor right-click menus - Bottom bar status labels and progress bar - Theme panel, path settings, warning notices, dropdown button - Editor text area and central widgets - Dialogs (save confirm, settings, print preview) - Update copyright years for modified files - Add REUSE dep5 entry for test/at/spi/ directory This allows AT-SPI/accessibility frameworks to properly identify and interact with all operable UI elements. Issue: V-1559
06e7ef7 to
c7df007
Compare
deepin pr auto review★ 总体评分:98分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 // src/widgets/window.cpp 或相关对话框触发位置补充缺失的无障碍名称设置
// 以保持与 test/at/spi/expected_names.yaml 测试用例的严格对齐
// 示例1:补充保存确认对话框的无障碍名称
DDialog *saveConfirmDialog = new DDialog(this);
saveConfirmDialog->setAccessibleName("SaveConfirmDialog");
saveConfirmDialog->setTitle(tr("Unsaved Changes"));
saveConfirmDialog->setMessage(tr("Do you want to save the changes?"));
// 示例2:补充设置对话框的无障碍名称(假设在打开设置的地方)
void Window::showSettingsDialog()
{
SettingsDialog *settingsDialog = new SettingsDialog(this);
settingsDialog->setAccessibleName("SettingsDialog");
settingsDialog->exec();
settingsDialog->deleteLater();
}
// 示例3:补充打印预览对话框的无障碍名称
void Window::showPrintPreview()
{
QPrintPreviewDialog *previewDialog = new QPrintPreviewDialog(this);
previewDialog->setAccessibleName("PrintPreview");
previewDialog->exec();
previewDialog->deleteLater();
} |
Summary
Add setAccessibleName and setObjectName for all interactive UI controls and assertion-required elements across the editor.
Changes
Related Issue
V-1559
Report
报告详见 Issue 评论附件。
Summary by Sourcery
Add AT-SPI accessible and object names across core editor UI components to improve screen reader and assistive technology support.
New Features:
Enhancements:
Tests: