Skip to content

chore: unused drop cppcheck ci - #83

Merged
zccrs merged 1 commit into
linuxdeepin:masterfrom
wineee:ci
Aug 7, 2026
Merged

chore: unused drop cppcheck ci#83
zccrs merged 1 commit into
linuxdeepin:masterfrom
wineee:ci

Conversation

@wineee

@wineee wineee commented Aug 7, 2026

Copy link
Copy Markdown
Member

log: Sync linuxdeepin/.github#801

Summary by Sourcery

CI:

  • Delete the cppcheck GitHub Actions workflow configuration.

@sourcery-ai

sourcery-ai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the cppcheck GitHub Actions workflow as part of syncing with the upstream .github configuration.

File-Level Changes

Change Details Files
Remove obsolete cppcheck CI workflow from GitHub Actions.
  • Delete the cppcheck.yml workflow file from .github/workflows
  • Stop running cppcheck as part of the repository's CI
.github/workflows/cppcheck.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wineee, zccrs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zccrs
zccrs merged commit 68b0a14 into linuxdeepin:master Aug 7, 2026
6 of 7 checks passed
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:75分

■ 【总体评价】

变更移除了PR静态代码分析工作流,导致代码质量保障机制缺失
逻辑正确但因移除关键CI质量门禁扣25分

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

本次变更为纯粹的文件删除操作,不涉及代码逻辑变更,未引入语法或逻辑错误
建议:无

  • 2.代码质量(存在严重问题)✕

变更直接删除了 .github/workflows/cppcheck.yml,彻底移除了基于 cppcheck 的自动化静态代码分析能力。虽然原文件第12行存在 cppchceck 拼写错误且第16行存在无意义的 - run: export 调试语句,但正确的做法应是修复这些缺陷并保留流水线,而非一刀切删除
潜在问题:丧失自动化代码审查拦截能力,后续合入代码将无法自动检测潜在的内存泄漏、空指针解引用等C/C++常见缺陷;代码库失去了重要的质量门禁
建议:恢复该工作流文件,修正第12行 cppchceckcppcheck,删除第16行无用的 export 调试步骤

  • 3.代码性能(无性能问题)✓

删除CI配置文件不影响目标产物的运行时性能表现
建议:无

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次变更为删除配置文件,未向代码库引入命令注入、路径遍历等实质性安全漏洞。原文件使用的 pull_request_target 触发器配合 ref: ${{ github.event.pull_request.head.sha }} 虽具有一定风险,但随着文件删除该风险已消除
建议:虽然当前无安全漏洞,但失去静态检查意味着未来可能引入未被发现的内存安全漏洞,强烈建议恢复该检查机制

■ 【改进建议代码示例】

name: cppcheck
on:
  pull_request_target:
    paths-ignore:
      - ".github/workflows/**"

concurrency:
  group: ${{ github.workflow }}-pull/${{ github.event.number }}
  cancel-in-progress: true

jobs:
  cppcheck:
    name: cppcheck
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
        with:
          ref: ${{ github.event.pull_request.head.sha }}
          persist-credentials: false
      - uses: linuxdeepin/action-cppcheck@main
        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}
          repository: ${{ github.repository }}
          pull_request_id: ${{ github.event.pull_request.number }}
          allow_approve: false

@wineee
wineee deleted the ci branch August 7, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants