WM-241: remove activate_session/deactivate_session requests - #85
WM-241: remove activate_session/deactivate_session requests#85deepin-wm wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Sorry @deepin-wm, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the private treeland<->ddm protocol definition by removing two now-unused session control requests from the XML protocol file, relying instead on native VT handling in wlroots/libseat. Sequence diagram for removed treeland_ddm session control requestssequenceDiagram
participant ddm
participant treeland
ddm->>treeland: activate_session
ddm->>treeland: deactivate_session
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
VT switching is now handled natively by wlroots/libseat (dde-seatd). ddm never sends activate_session/deactivate_session requests, and the treeland handlers that implemented them have been removed, so these dead protocol requests are dropped from treeland-ddm-v1.xml. Verified in ddm: TreelandConnector.cpp only calls treeland_ddm_v1_switch_to_greeter/switch_to_user; 0 references to activate_session/deactivate_session in ddm source. Related: WM-241
ec2d85d to
1a466e5
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-wm The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin pr auto review★ 总体评分:95分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 diff --git a/xml/treeland-ddm-v1.xml b/xml/treeland-ddm-v1.xml
index 6fd1154..1a3fd60 100644
--- a/xml/treeland-ddm-v1.xml
+++ b/xml/treeland-ddm-v1.xml
@@ -22,18 +22,6 @@
</description>
<arg name="username" type="string"/>
</request>
- <request name="activate_session">
- <description summary="activate wayland session">
- Activate treeland session. This will makes treeland try to take
- control of screen.
- </description>
- </request>
- <request name="deactivate_session">
- <description summary="deactivate wayland session">
- Deactivate treeland session. This will release control of the
- screen, but not to close the current seats.
- </description>
- </request>
<request name="enable_render">
<description summary="start treeland rendering">
Enable treeland rendering. This is primarily called after |
Related to WM-241
Drop the activate_session / deactivate_session requests from
xml/treeland-ddm-v1.xml. VT switching is now handled natively by
wlroots/libseat (dde-seatd), ddm never sends these requests, and the
treeland handlers that implemented them have been removed in the
companion treeland PR, so these dead protocol requests are no longer
needed.
This is a private treeland<->ddm protocol; removing unused requests is
safe. No version bump is required — removing requests does not break
clients (and no client sends them). ddm does not reference these
requests and builds against either the old or new protocol.
Summary by Sourcery
Remove unused treeland-ddm protocol requests related to session activation and deactivation, relying on native VT switching instead.