Skip to content

protocols: mark all treeland protocols as experimental with no compatibility guarantees - #86

Merged
zccrs merged 1 commit into
linuxdeepin:masterfrom
deepin-wm:agent/wm-pl/30790fbc
Aug 13, 2026
Merged

protocols: mark all treeland protocols as experimental with no compatibility guarantees#86
zccrs merged 1 commit into
linuxdeepin:masterfrom
deepin-wm:agent/wm-pl/30790fbc

Conversation

@deepin-wm

@deepin-wm deepin-wm commented Aug 13, 2026

Copy link
Copy Markdown

Summary

All Treeland Wayland protocol extensions are experimental and may change at any time, including in backward-incompatible ways, without any compatibility guarantees.

Closes: WM-248

Changes

XML protocol files (22 files in xml/)

Unified experimental disclaimer added to the protocol-level <description> in every XML file:

Warning! This protocol is EXPERIMENTAL and under active development.
It may change at any time, including in backward-incompatible ways,
without incrementing the interface major version and without prior
notice. No compatibility guarantees of any kind are provided. Clients
and compositors must track the upstream definition in treeland-protocols
and must not rely on the current interface names, requests, events, or
semantics remaining stable across releases.
  • 6 files with existing protocol-level <description>: disclaimer appended (capture, input-manager, keyboard-state-notify, remote-subsurface, wine-window-management, wine-window-state)
  • 16 files without protocol-level <description>: new <description> block added after <copyright> (app-id-resolver, dde-shell, ddm, foreign-toplevel, output-manager, personalization, prelaunch-splash-v1/v2, screensaver, shortcut-v1/v2, virtual-output-manager, wallpaper-color, wallpaper-manager, wallpaper-shell, window-management)

Old warning cleanup (7 files)

Removed old "testing phase" warning blocks from interface descriptions in:

  • dde-shell (2 blocks), foreign-toplevel (3 blocks), personalization (5 blocks), screensaver (1 block), shortcut-v1 (2 blocks), shortcut-v2 (1 block)
  • keyboard-state-notify: old warning in protocol-level description replaced with new disclaimer

The old wording ("Backward incompatible changes can only be done by creating a new major version") promised version-bump discipline, which directly contradicts the issue requirement of "no compatibility guarantees." These blocks were removed to avoid self-contradicting documentation.

Documentation

  • README.md: added "Experimental status" section
  • README.zh_CN.md: added "实验性状态" section

Skill template & rules (prevent future regression)

  • treeland-protocol-template.xml: pre-populated experimental disclaimer in protocol-level <description>
  • treeland-wayland-protocol-rules.md: added section 12 requiring the experimental disclaimer in every protocol-level <description>

Notes

  • No interface version bumps, no since additions — pure documentation change
  • No CMakeLists.txt changes — no files added or removed
  • All 22 XML files verified well-formed

Summary by Sourcery

Clarify that all Treeland Wayland protocols in this repository are experimental and provide no compatibility guarantees, and align protocol XMLs, templates, and authoring rules with that status.

Enhancements:

  • Add a standardized experimental disclaimer to the protocol-level descriptions of all Treeland protocol XML files, and remove obsolete per-interface "testing phase" warnings that implied version-bump stability.
  • Update the Treeland protocol XML template to include the experimental disclaimer by default, and extend the internal authoring rules to require it exactly once per protocol-level description.

Documentation:

  • Add an "Experimental status" section to the English and Chinese READMEs documenting that all Treeland Wayland protocol extensions are experimental and may change in backward-incompatible ways.

…ibility guarantees

All Treeland Wayland protocol extensions are experimental and may change
at any time, including in backward-incompatible ways, without any
compatibility guarantees.

Changes:
- Add unified experimental disclaimer to protocol-level <description> in
  all 22 XML protocol files (6 files with existing description: appended;
  16 files without: new protocol-level <description> added)
- Remove old 'testing phase' warning blocks from interface descriptions
  in 7 files (dde-shell, foreign-toplevel, personalization, screensaver,
  shortcut-v1, shortcut-v2, keyboard-state-notify) — the old wording
  promised version-bump discipline which contradicts 'no compatibility
  guarantees'
- Replace old warning in keyboard-state-notify protocol-level description
  with the new experimental disclaimer
- Add 'Experimental status' section to README.md and README.zh_CN.md
- Pre-populate experimental disclaimer in treeland-protocol-template.xml
- Add rule 12 to treeland-wayland-protocol-rules.md requiring the
  experimental disclaimer in every protocol-level <description>

No interface version bumps, no wire protocol changes.

Closes: WM-248

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @deepin-wm, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@sourcery-ai

sourcery-ai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Reviewer's Guide

Marks all Treeland Wayland protocols as explicitly experimental by standardizing a single disclaimer in protocol-level descriptions, removing contradictory old testing-phase warnings, and updating documentation and authoring rules to prevent future regressions.

File-Level Changes

Change Details Files
Standardized experimental disclaimer across all Treeland protocol XMLs at the protocol level.
  • Added a new protocol-level containing the experimental disclaimer to XML files that previously lacked one.
  • Appended the experimental disclaimer text to existing protocol-level blocks without altering interface definitions or versions.
  • Ensured the disclaimer wording is identical across all protocols and appears only once per XML at the protocol level.
xml/treeland-app-id-resolver-v1.xml
xml/treeland-dde-shell-v1.xml
xml/treeland-ddm-v1.xml
xml/treeland-foreign-toplevel-manager-v1.xml
xml/treeland-output-manager-v1.xml
xml/treeland-personalization-manager-v1.xml
xml/treeland-prelaunch-splash-v1.xml
xml/treeland-prelaunch-splash-v2.xml
xml/treeland-screensaver-v1.xml
xml/treeland-shortcut-manager-v1.xml
xml/treeland-shortcut-manager-v2.xml
xml/treeland-virtual-output-manager-v1.xml
xml/treeland-wallpaper-color-v1.xml
xml/treeland-wallpaper-manager-unstable-v1.xml
xml/treeland-wallpaper-shell-unstable-v1.xml
xml/treeland-window-management-v1.xml
xml/treeland-capture-unstable-v1.xml
xml/treeland-input-manager-unstable-v1.xml
xml/treeland-keyboard-state-notify-unstable-v1.xml
xml/treeland-remote-subsurface-unstable-v1.xml
xml/treeland-wine-window-management-unstable-v1.xml
xml/treeland-wine-window-state-unstable-v1.xml
Removed legacy testing-phase warnings that promised version-bump discipline from interface descriptions to align with the new experimental policy.
  • Deleted testing-phase warning paragraphs from multiple interface-level blocks so that only the protocol-level disclaimer communicates status.
  • Replaced the old protocol-level warning in keyboard-state-notify with the new experimental disclaimer wording.
xml/treeland-personalization-manager-v1.xml
xml/treeland-foreign-toplevel-manager-v1.xml
xml/treeland-dde-shell-v1.xml
xml/treeland-shortcut-manager-v1.xml
xml/treeland-shortcut-manager-v2.xml
xml/treeland-screensaver-v1.xml
xml/treeland-keyboard-state-notify-unstable-v1.xml
Updated top-level documentation to state the experimental status of all Treeland Wayland protocols.
  • Added an Experimental status section describing the lack of compatibility guarantees and the need to track upstream definitions.
  • Added a Chinese-language equivalent Experimental status section with matching semantics.
README.md
README.zh_CN.md
Embedded the experimental disclaimer into authoring tooling to enforce it for all future protocols.
  • Updated the protocol template XML to include the experimental disclaimer in the protocol-level by default.
  • Extended the protocol authoring rules with a new section requiring the disclaimer in every protocol XML and forbidding the old testing-phase wording or duplication inside interfaces.
  • Added a checklist item to verify the presence of the disclaimer when finishing an XML file.
.agents/skills/treeland-wayland-protocol/assets/treeland-protocol-template.xml
.agents/skills/treeland-wayland-protocol/references/treeland-wayland-protocol-rules.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码完成了协议文档规范性声明的全局升级,逻辑严密且无任何瑕疵。
文本替换精准一致,规则文档与模板同步更新,完美契合规范要求,故满分。

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

本次变更涉及20余个XML与Markdown文件,均为纯文本级别的节点增删改操作,不涉及任何执行逻辑、条件分支或内存管理。XML标签闭合正确,Markdown格式规范,无任何语法错误。
潜在问题:无
建议:无

  • 2.代码质量(优秀)✓

变更展现出极高的工程规范性。将原先散布在各<interface>内部重复的“testing phase”警告统一提取至<protocol>级别的<description>中,遵循了DRY原则。同时通过在treeland-wayland-protocol-rules.md中新增第12节规则,并在模板文件中预置声明,从流程上彻底杜绝了未来新增协议时遗漏免责声明的可能。
潜在问题:无
建议:无

  • 3.代码性能(无性能问题)✓

本次修改对象为静态的XML协议定义文件与Markdown说明文档,不参与运行时编译或动态加载解析的性能消耗路径,对系统运行性能无任何影响。
潜在问题:无
建议:无

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次提交全部为静态声明文本的规范化调整,不包含任何可执行代码、脚本或动态解析逻辑,彻底排除了命令注入、路径遍历、缓冲区溢出等安全风险面。

  • 建议:无需修复,保持当前的文档级安全基线即可。

■ 【改进建议代码示例】

<!-- 当前变更已完美符合所有规范,无需额外改进代码示例 -->
<!-- 以下为符合本次新增第12节规则的标准协议文件头结构示意 -->
<protocol name="treeland_example_protocol_v1">
    <copyright>
        SPDX-FileCopyrightText: 2025 UnionTech Software Technology Co., Ltd.
        SPDX-License-Identifier: MIT
    </copyright>

    <description summary="example protocol">
        Warning! This protocol is EXPERIMENTAL and under active development.
        It may change at any time, including in backward-incompatible ways,
        without incrementing the interface major version and without prior
        notice. No compatibility guarantees of any kind are provided. Clients
        and compositors must track the upstream definition in treeland-protocols
        and must not rely on the current interface names, requests, events, or
        semantics remaining stable across releases.
    </description>

    <interface name="treeland_example_manager_v1" version="1">
        <!-- 接口定义,不再包含实验性警告 -->
    </interface>
</protocol>

@zccrs
zccrs requested a review from wineee August 13, 2026 07:07
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-wm, wineee

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zccrs
zccrs merged commit 02f9bd0 into linuxdeepin:master Aug 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants