[codex] raise Treeland service resource priority - #977
Merged
zccrs merged 1 commit intoJun 15, 2026
Conversation
Raise Treeland DDM-mode systemd service to highest normal CPU, I/O, and OOM-protection priorities. Move dde-seatd socket environment ownership to treeland.service. Log: 提升 Treeland 服务资源优先级到最高普通优先级 Influence: 提升 Treeland 服务的性能表现，确保系统流畅运行
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts Treeland's systemd unit to run with maximum normal CPU/I/O priority and strongest OOM protection, while centralizing seatd socket environment configuration into the service. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Raising Treeland to full realtime CPU/IO scheduling with Nice=-20, CPUSchedulingPolicy=rr, and IOSchedulingClass=realtime plus OOMScoreAdjust=-1000 risks starving other services and making the system hard to recover under load; consider whether a high non-realtime scheduling class or more moderate weights would achieve the goal with less impact.
- CPUSchedulingPolicy=rr and CPUSchedulingPriority=20 require CAP_SYS_NICE and may fail or be ignored on some deployments; it would be good to confirm how this behaves on systems without those capabilities and whether you need a fallback configuration.
- Moving SEATD_SOCK into treeland.service’s Environment ties seatd socket configuration directly to this unit; consider whether this should instead live in a shared environment (e.g., EnvironmentFile or seatd-related unit) so that other consumers of dde-seatd.sock don’t diverge in their configuration.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Raising Treeland to full realtime CPU/IO scheduling with Nice=-20, CPUSchedulingPolicy=rr, and IOSchedulingClass=realtime plus OOMScoreAdjust=-1000 risks starving other services and making the system hard to recover under load; consider whether a high non-realtime scheduling class or more moderate weights would achieve the goal with less impact.
- CPUSchedulingPolicy=rr and CPUSchedulingPriority=20 require CAP_SYS_NICE and may fail or be ignored on some deployments; it would be good to confirm how this behaves on systems without those capabilities and whether you need a fallback configuration.
- Moving SEATD_SOCK into treeland.service’s Environment ties seatd socket configuration directly to this unit; consider whether this should instead live in a shared environment (e.g., EnvironmentFile or seatd-related unit) so that other consumers of dde-seatd.sock don’t diverge in their configuration.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
TAG Bot New tag: 0.8.9 |
zccrs
approved these changes
Jun 15, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-wm, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise Treeland DDM-mode systemd service to highest normal CPU, I/O, and OOM-protection priorities. Move dde-seatd socket environment ownership to treeland.service.
Changes:
Environment=SEATD_SOCK=/run/dde-seatd.sockto own the seatd socket configurationOOMScoreAdjust=-300toOOMScoreAdjust=-1000(maximum protection)Nice=-15toNice=-20(highest nice priority)CPUWeight=10000(high CPU weight)CPUSchedulingPolicy=rr(round-robin realtime scheduling)CPUSchedulingPriority=20(realtime priority level)IOWeight=10000(high I/O weight)IOSchedulingClass=realtime(realtime I/O scheduling)IOSchedulingPriority=0(highest I/O priority)This PR replaces closed PR #932 which was targeting the old/master branch.
Summary by Sourcery
Increase Treeland systemd service priority and own seatd socket configuration for DDM mode.
Enhancements: