Joplin: Remove authentication for /api endpoint - #814
Open
NaruZosa wants to merge 1 commit into
Open
Conversation
Removed authentication for the /api endpoint, as this breaks communication via the client application which handles authentication natively, or for the /api/ping endpoint which shouldn't be protected.
NaruZosa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed authentication for the /api endpoint, as this breaks communication via the client application which handles authentication natively, or for the /api/ping endpoint which shouldn't be protected.
Benefits of this PR and context
Fixes communication with the Joplin clients when using authentication such as authelia or tinyauth
How Has This Been Tested?
Used template on my setup with tinyauth enabled
Confirmed /api/ping is reachable without auth
confirmed mobile and desktop apps can communicate with the joplin server
Confirmed auth is required for accessing non-api endpoints, such as the root
Source / References