Skip to content

chore(application): replace raise logic to one place #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
literally-user merged 1 commit into from
Aug 8, 2026
Merged

chore(application): replace raise logic to one place #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 31 additions & 42 deletions src/conode/application/services/access_control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def check(
required_entity: EntityType,
entity_id: RolePermissionEntityId | None,
company: Company,
) -> bool:
) -> None:
for perm in permissions:
if (
PERMISSION_LEVEL[perm.permission]
Expand All @@ -85,16 +85,16 @@ def check(
continue

if perm.entity_type == EntityType.COMPANY and perm.entity_id == company.id:
return True
return

if (
entity_id is not None
and perm.entity_type == required_entity
and perm.entity_id == entity_id
):
return True
return

return False
raise NotEnoughRightsError("Not enough rights to perform operation", None)

async def ensure_user_can_manipulate_group(
self,
Expand All @@ -105,14 +105,13 @@ async def ensure_user_can_manipulate_group(

group_company = await self.company_repository.get_by_id(group.company_id)

if not self.check(
self.check(
permissions=permissions,
required_permission=PermissionType.MODIFY,
required_entity=EntityType.GROUP,
entity_id=group.id,
company=group_company,
):
raise NotEnoughRightsError("Not enough rights to perform operation", None)
)

async def ensure_user_can_manipulate_role(
self,
Expand All @@ -123,14 +122,13 @@ async def ensure_user_can_manipulate_role(

role_company = await self.company_repository.get_by_id(role.owner_company_id)

if not self.check(
self.check(
permissions=permissions,
required_permission=PermissionType.MODIFY,
required_entity=EntityType.COMPANY,
entity_id=None,
company=role_company,
):
raise NotEnoughRightsError("Not enough rights to perform operation", None)
)

async def ensure_user_can_manipulate_context(
self,
Expand All @@ -141,14 +139,13 @@ async def ensure_user_can_manipulate_context(

context_company = await self.company_repository.get_by_id(context.company_id)

if not self.check(
self.check(
permissions=permissions,
required_permission=PermissionType.MODIFY,
required_entity=EntityType.GROUP,
entity_id=context.id,
company=context_company,
):
raise NotEnoughRightsError("Not enough rights to perform operation", None)
)

async def ensure_user_can_view_group(
self,
Expand All @@ -159,14 +156,13 @@ async def ensure_user_can_view_group(

group_company = await self.company_repository.get_by_id(context.company_id)

if not self.check(
self.check(
permissions=permissions,
required_permission=PermissionType.READ,
required_entity=EntityType.GROUP,
entity_id=context.id,
company=group_company,
):
raise NotEnoughRightsError("Not enough rights to perform operation", None)
)

async def ensure_user_can_view_context(
self,
Expand All @@ -177,14 +173,13 @@ async def ensure_user_can_view_context(

context_company = await self.company_repository.get_by_id(context.company_id)

if not self.check(
self.check(
permissions=permissions,
required_permission=PermissionType.READ,
required_entity=EntityType.CONTEXT,
entity_id=context.id,
company=context_company,
):
raise NotEnoughRightsError("Not enough rights to perform operation", None)
)

async def ensure_user_can_create_groups(
self,
Expand All @@ -193,14 +188,13 @@ async def ensure_user_can_create_groups(
) -> None:
permissions = await self._get_all_permissions(user)

if not self.check(
self.check(
permissions=permissions,
required_permission=PermissionType.MODIFY,
required_entity=EntityType.COMPANY,
entity_id=None,
company=target_company,
):
raise NotEnoughRightsError("Not enough rights to perform operation", None)
)

async def ensure_user_can_create_contexts(
self,
Expand All @@ -209,14 +203,13 @@ async def ensure_user_can_create_contexts(
) -> None:
permissions = await self._get_all_permissions(user)

if not self.check(
self.check(
permissions=permissions,
required_permission=PermissionType.MODIFY,
required_entity=EntityType.COMPANY,
entity_id=None,
company=target_company,
):
raise NotEnoughRightsError("Not enough rights to perform operation", None)
)

async def ensure_user_can_create_roles(
self,
Expand All @@ -225,14 +218,13 @@ async def ensure_user_can_create_roles(
) -> None:
permissions = await self._get_all_permissions(user)

if not self.check(
self.check(
permissions=permissions,
required_permission=PermissionType.MODIFY,
required_entity=EntityType.COMPANY,
entity_id=None,
company=target_company,
):
raise NotEnoughRightsError("Not enough rights to perform operation", None)
)

async def ensure_user_can_send_offers(
self,
Expand All @@ -241,14 +233,13 @@ async def ensure_user_can_send_offers(
) -> None:
permissions = await self._get_all_permissions(user)

if not self.check(
self.check(
permissions=permissions,
required_permission=PermissionType.MODIFY,
required_entity=EntityType.COMPANY,
entity_id=None,
company=from_company,
):
raise NotEnoughRightsError("Not enough rights to perform operation", None)
)

async def ensure_user_can_manipulate_offers(
self,
Expand All @@ -257,14 +248,13 @@ async def ensure_user_can_manipulate_offers(
) -> None:
permissions = await self._get_all_permissions(user)

if not self.check(
self.check(
permissions=permissions,
required_permission=PermissionType.MODIFY,
required_entity=EntityType.COMPANY,
entity_id=None,
company=to_company,
):
raise NotEnoughRightsError("Not enough rights to perform operation", None)
)

async def ensure_user_can_manipulate_groups(
self,
Expand All @@ -279,21 +269,20 @@ async def ensure_user_can_manipulate_groups(
check_targets = zip(groups, companies, strict=True)

for group, company in check_targets:
if not self.check(
self.check(
permissions=permissions,
required_permission=PermissionType.MODIFY,
required_entity=EntityType.GROUP,
entity_id=group.id,
company=company,
):
raise NotEnoughRightsError(
"Not enough rights to perform operation", None
)
)

def ensure_user_can_verify_companies(self, user: User) -> None:
def _ensure_user_admin(self, user: User) -> None:
if user.system_role != UserSystemRole.ADMIN:
raise NotEnoughRightsError("Not enough rights to perform operation", None)

def ensure_user_can_verify_companies(self, user: User) -> None:
self._ensure_user_admin(user)

def ensure_user_can_manipulate_user_profiles(self, user: User) -> None:
if user.system_role != UserSystemRole.ADMIN:
raise NotEnoughRightsError("Not enough rights to perform operation", None)
self._ensure_user_admin(user)
Loading