Add GitHub action#68
Closed
alan-george-lk wants to merge 6 commits into
Closed
Conversation
TypeScript 6.x errors (TS5107/TS5101) on `moduleResolution: "node"` (an alias for the deprecated `node10`) and on `baseUrl`, breaking `pnpm build`. The entrypoint imports only package specifiers (no relative imports), so switching to `module`/`moduleResolution` "NodeNext" is behavior-preserving, and the unused `baseUrl` (no `paths` map) can be dropped. Co-authored-by: Cursor <cursoragent@cursor.com>
Adds a root action.yml so other projects' CI can stand up this token server and consume its /createToken endpoint (mirrors the livekit/dev-server-action model). The action builds and runs the server's own code from $GITHUB_ACTION_PATH and waits for readiness, emitting `token-url` and `log-path` outputs. Also makes the listen port configurable via the PORT env var so the action's `port` input is honored and consumers aren't locked to 3000. Co-authored-by: Cursor <cursoragent@cursor.com>
1egoman
reviewed
Jun 23, 2026
1egoman
left a comment
1egoman
left a comment
Contributor
There was a problem hiding this comment.
Generally makes sense to me, but I'd like @rektdeckard to give the final approval since I want to make sure adding the action in here isn't too antithetical to the goal of this being an example.
Author
@1egoman Yeah fair play -- happy to move this elsewhere or start a new one from scratch. Thanks |
Author
|
After pondering/discussion with @1egoman, deciding to move an action to a separate repo as to not pollute the intent of this example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TOKEN_SERVER_PORTfor deconflicting port numbers with existing processes if needed, otherwise falls back to existing3000default