[dev] add tvm-ffi as a new workspace module by LoSealL · Pull Request #12 · llteco/vila

LoSealL · 2026-04-03T15:15:35Z

[WORKSPACE]

load("@vila//vila:workspace2.bzl", vila_workspace2 = "workspace")
vila_workspace2(tvm_ffi = True)

[BZLMOD]

tvm_ffi_ext = use_extension("@vila//vila/bazel/bzlmod:extensions.bzl", "tvm_ffi_extension")
use_repo(tvm_ffi_ext, "tvm_ffi")

[SOURCE]

load("@rules_cc//cc:defs.bzl", "cc_binary")
load("@rules_python//python:defs.bzl", "py_test")
load("@vila_pip_deps//:requirements.bzl", "requirement")
load("//vila/bazel/vila:vila.bzl", "vila_cc_test")

cc_binary(
    name = "tvm_ffi_call",
    srcs = ["tvm_ffi_call.cpp"],
    linkshared = True,
    deps = [
        "@fmt",
        "@tvm_ffi",
    ],
)

py_test(
    name = "tvm_ffi_call_test",
    srcs = ["tvm_ffi_call_test.py"],
    data = [":tvm_ffi_call"],
    deps = [
        requirement("apache-tvm-ffi"),
        requirement("numpy"),
        requirement("typing-extensions"),
    ],
)

@fmt

[WORKSPACE] ``` load("@vila//vila:workspace2.bzl", vila_workspace2 = "workspace") vila_workspace2(tvm_ffi = True) ``` [BZLMOD] ``` tvm_ffi_ext = use_extension("@vila//vila/bazel/bzlmod:extensions.bzl", "tvm_ffi_extension") use_repo(tvm_ffi_ext, "tvm_ffi") ``` [SOURCE] ``` load("@rules_cc//cc:defs.bzl", "cc_binary") load("@rules_python//python:defs.bzl", "py_test") load("@vila_pip_deps//:requirements.bzl", "requirement") load("//vila/bazel/vila:vila.bzl", "vila_cc_test") cc_binary( name = "tvm_ffi_call", srcs = ["tvm_ffi_call.cpp"], linkshared = True, deps = [ "@fmt", "@tvm_ffi", ], ) py_test( name = "tvm_ffi_call_test", srcs = ["tvm_ffi_call_test.py"], data = [":tvm_ffi_call"], deps = [ requirement("apache-tvm-ffi"), requirement("numpy"), requirement("typing-extensions"), ], ) ```

Copilot

Pull request overview

Adds an optional Bazel workspace/module integration for TVM FFI (from the apache-tvm-ffi PyPI package), plus a small C++/Python smoke test to validate loading and calling into a TVM FFI-exported function.

Changes:

Introduces a tvm_ffi_configure repository rule and wires it into both legacy WORKSPACE flow and Bzlmod via a new module extension.
Adds tests/vila targets to build a shared library that exports a TVM FFI function, and a py_test that loads and exercises it.
Updates Python tooling (ruff) and CI to install the required PyPI dependencies for the TVM FFI test.

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
WORKSPACE	Enables `tvm_ffi` in `vila_workspace2` and adds `pip_parse` for test deps (legacy WORKSPACE flow).
vila/workspace2.bzl	Adds `tvm_ffi` toggle and calls `tvm_ffi_configure` when enabled.
vila/bazel/tvm_ffi_configure.bzl	New repository rule to discover include/lib paths via `python -m tvm_ffi.config` and generate `@tvm_ffi` build targets.
vila/bazel/toolchains/sycl_cc_toolchain_config.bzl	Filters out invalid include paths for toolchain config generation.
vila/bazel/toolchains/sycl_cc_configure.bzl	Improves template list entry concatenation for MSVC SYCL include dirs.
vila/bazel/bzlmod/extensions.bzl	Adds a new `tvm_ffi_extension` module extension for Bzlmod.
tests/vila/tvm_ffi_call.cpp	New shared library exporting a TVM FFI function operating on tensors.
tests/vila/tvm_ffi_call_test.py	New Python test loading the shared library and validating tensor results.
tests/vila/requirements_tvm_ffi_test.txt	New pinned PyPI requirements used for the TVM FFI Python test.
tests/vila/BUILD.bazel	Adds `cc_binary` shared library build and `py_test` wiring with pip requirements.
pyproject.toml	Adds Ruff configuration.
MODULE.bazel	Adds rules_python pip parsing for test requirements and wires in `tvm_ffi_extension`.
.pre-commit-config.yaml	Replaces black/isort/flake8 hooks with ruff (lint + format).
.gitignore	Ignores a local Claude settings file.
.github/workflows/build-tests.yml	Installs `tests/vila/requirements_tvm_ffi_test.txt` in CI before Bazel steps.
.claude/CLAUDE.md	Adds repo guidance documentation for Claude Code.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-03T15:39:08Z

+vila_workspace2(
+    sycl = False,
+    tvm_ffi = True,
+)


WORKSPACE previously enabled SYCL via sycl = True, but this change forces sycl = False while adding tvm_ffi = True. This looks unrelated to the PR’s stated goal (adding tvm-ffi) and will change developer builds unexpectedly. Consider preserving the prior sycl = True setting (or omit the argument to keep the existing behavior) and only add tvm_ffi = True.

Copilot · 2026-04-03T15:39:08Z

+    )
+    dlpack_dir = result.stdout.strip()


The result of python -m tvm_ffi.config --dlpack-includedir is used without checking return_code. If the command fails or returns an empty path, repository_ctx.symlink(dlpack_dir, "dlpack") will fail with a confusing error. Please check return_code (and that stdout.strip() is non-empty) and fail with a clear message like the --includedir step.

Suggested change

)

dlpack_dir = result.stdout.strip()

)

# If DLPack headers cannot be located, fail clearly before symlinking

if result.return_code != 0:

fail("DLPack include directory not found. Ensure apache-tvm-ffi is installed correctly.")

dlpack_dir = result.stdout.strip()

if not dlpack_dir:

fail("DLPack include directory is empty. Ensure apache-tvm-ffi is installed correctly.")

Copilot · 2026-04-03T15:39:09Z

+        [str(python_path), "-m", "tvm_ffi.config", "--libfiles"],
+        quiet = False,
+    )
+


The --libfiles query also doesn’t validate return_code. If it fails, lib_files becomes ['']/empty and the generated BUILD will silently omit link inputs, leading to later link-time errors that are hard to diagnose. Please validate return_code and fail early with a helpful message (and optionally echo stderr).

Suggested change

# If library discovery fails, stop early with a helpful error instead of

# generating a BUILD file that silently omits link inputs.

if result.return_code != 0:

error_msg = "Failed to query TVM FFI library files. Install with: pip install apache-tvm-ffi"

if result.stderr.strip():

error_msg += "\nCommand stderr:\n" + result.stderr.strip()

fail(error_msg)

Copilot · 2026-04-03T15:39:09Z

+# Define the repository rule for Bazel
+# Repository rules are used to fetch and configure external dependencies.
+# This rule is called once per Bazel invocation to set up the TVM FFI dependency.
+tvm_ffi_configure = repository_rule(implementation = _tvm_ffi_configure)


This repository rule depends on the host Python environment (PATH + installed apache-tvm-ffi). It should be marked as a local/configure-time repository to avoid incorrect reuse across machines and to ensure it reruns when relevant environment variables change. Consider adding local = True and an environ = [...] list (e.g., PATH/PYTHONPATH/virtualenv variables) to the repository_rule(...) declaration.

Suggested change

tvm_ffi_configure = repository_rule(implementation = _tvm_ffi_configure)

tvm_ffi_configure = repository_rule(

implementation = _tvm_ffi_configure,

local = True,

environ = [

"PATH",

"PYTHONPATH",

"PYTHONHOME",

"VIRTUAL_ENV",

"CONDA_PREFIX",

],

)

Copilot · 2026-04-03T15:39:09Z

+#include <tvm/ffi/tvm_ffi.h>
+
+#include <cstring>
+#include <cstdint>


malloc/free are used but <cstdlib> isn’t included. Some toolchains will fail to compile this (especially with strict warning settings). Please include <cstdlib> (or use std::malloc/std::free accordingly).

Suggested change

#include <cstdint>

#include <cstdint>

#include <cstdlib>

Copilot · 2026-04-03T15:39:10Z

+    # Prefer Bazel runfiles, then local workspace build outputs.
+    candidates = [
+        Path(os.environ.get("TEST_SRCDIR", "")) / f"_main/tests/vila/{lib_name}",
+        Path(os.environ.get("RUNFILES_DIR", "")) / f"_main/tests/vila/{lib_name}",
+        file_dir / lib_name,
+        workspace_root / f"bazel-bin/tests/vila/{lib_name}",
+        Path.cwd() / lib_name,
+    ]


The runfiles lookup hard-codes the repository name _main (e.g. .../_main/tests/vila/...). Under non-bzlmod builds (or if the workspace name differs), the runfiles root won’t be _main, so the shared library won’t be found. Prefer using TEST_WORKSPACE (if set) or derive the repo name from runfiles metadata, and check both _main and the actual workspace name.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

sonarqubecloud · 2026-04-03T15:52:24Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

LoSealL force-pushed the dev branch from 96bb8df to 889a25a Compare April 3, 2026 15:21

LoSealL force-pushed the dev branch from 889a25a to 7638a1e Compare April 3, 2026 15:26

LoSealL requested a review from Copilot April 3, 2026 15:34

Copilot started reviewing on behalf of LoSealL April 3, 2026 15:35 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

Apply suggestions from code review

b2a79f4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

LoSealL merged commit cf12b24 into main Apr 3, 2026
3 checks passed

LoSealL deleted the dev branch April 3, 2026 15:59

Navigation Menu

[dev] add tvm-ffi as a new workspace module - #12

[dev] add tvm-ffi as a new workspace module#12
LoSealL merged 2 commits into
mainfrom
dev

LoSealL commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 3, 2026

Uh oh!

Uh oh!

Copilot AI Apr 3, 2026

Uh oh!

Copilot AI Apr 3, 2026

Uh oh!

Uh oh!

Copilot AI Apr 3, 2026

Uh oh!

Copilot AI Apr 3, 2026

Uh oh!

Copilot AI Apr 3, 2026

Uh oh!

Uh oh!

sonarqubecloud Bot commented Apr 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-    )
-    dlpack_dir = result.stdout.strip()
+    )
+    # If DLPack headers cannot be located, fail clearly before symlinking
+    if result.return_code != 0:
+        fail("DLPack include directory not found. Ensure apache-tvm-ffi is installed correctly.")
+    dlpack_dir = result.stdout.strip()
+    if not dlpack_dir:
+        fail("DLPack include directory is empty. Ensure apache-tvm-ffi is installed correctly.")

+    # If library discovery fails, stop early with a helpful error instead of
+    # generating a BUILD file that silently omits link inputs.
+    if result.return_code != 0:
+        error_msg = "Failed to query TVM FFI library files. Install with: pip install apache-tvm-ffi"
+        if result.stderr.strip():
+            error_msg += "\nCommand stderr:\n" + result.stderr.strip()
+        fail(error_msg)

-tvm_ffi_configure = repository_rule(implementation = _tvm_ffi_configure)
+tvm_ffi_configure = repository_rule(
+    implementation = _tvm_ffi_configure,
+    local = True,
+    environ = [
+        "PATH",
+        "PYTHONPATH",
+        "PYTHONHOME",
+        "VIRTUAL_ENV",
+        "CONDA_PREFIX",
+    ],
+)

Conversation

LoSealL commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented Apr 3, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants