bolt: add tx_add_output codec - #221
Merged
Merged
Conversation
erickcestari
force-pushed
the
tx-add-output-codec
branch
from
August 28, 2026 12:20
f53e570 to
9f63f2a
Compare
NishantBansal2003
approved these changes
Aug 31, 2026
erickcestari
force-pushed
the
tx-add-output-codec
branch
from
September 1, 2026 16:45
9f63f2a to
5fa8b29
Compare
This was referenced Sep 8, 2026
erickcestari
force-pushed
the
tx-add-output-codec
branch
from
September 16, 2026 14:36
5fa8b29 to
f291e9c
Compare
morehouse
approved these changes
Sep 21, 2026
Comment on lines
+43
to
+46
| let channel_id = ChannelId::read(&mut cursor)?; | ||
| let serial_id = u64::read(&mut cursor)?; | ||
| let sats = u64::read(&mut cursor)?; | ||
| let script = Vec::<u8>::read(&mut cursor)?; |
Collaborator
There was a problem hiding this comment.
nit: can use WireFormat::read for all of these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersede #26