Skip to content

chore(fonts): remove SharpSans - #80

Merged
rhayasidajr merged 2 commits into
mainfrom
EDGE-3467
Jun 30, 2026
Merged

chore(fonts): remove SharpSans#80
rhayasidajr merged 2 commits into
mainfrom
EDGE-3467

Conversation

@rhayasidajr

@rhayasidajr rhayasidajr commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Types of changes

  • Chore

Description of the proposed changes

Remove SharpSans typefaces

Screenshots

image

Summary by CodeRabbit

  • New Features
    • Updated the site’s typography to use a new Google font family for body and heading text.
    • Expanded available font weights for better visual consistency across the app.
  • Bug Fixes
    • Aligned title styling with the updated font setup for a more consistent appearance.
  • Chores
    • Removed unused font-loading setup and simplified styling imports.

@rhayasidajr
rhayasidajr requested a review from a team as a code owner June 30, 2026 13:48
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Replaces the custom SharpSans font (loaded via gatsby-plugin-web-font-loader and @font-face in typography.css) with Plus Jakarta Sans loaded via gatsby-plugin-google-fonts. The theme font stacks, Layout.js import, and Title font-weight are updated accordingly.

Changes

Font Migration: SharpSans → Plus Jakarta Sans

Layer / File(s) Summary
Font loader config, theme, and component updates
gatsby-config.js, package.json, src/styles/theme.js, src/components/Layout.js, src/components/Title.js
Adds Plus Jakarta Sans (weights 500/600/700) to gatsby-plugin-google-fonts; removes gatsby-plugin-web-font-loader dependency and typography.css (which held SharpSans @font-face declarations); updates fonts.body and fonts.title in the theme to 'Plus Jakarta Sans'; drops the typography.css import from Layout.js; changes Title font-weight from 900 to 700.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: removing SharpSans fonts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch EDGE-3467

Comment @coderabbitai help to get the list of available commands.

@rhayasidajr rhayasidajr self-assigned this Jun 30, 2026
@netlify

netlify Bot commented Jun 30, 2026

Copy link
Copy Markdown

Deploy Preview for loadsmart-engineering ready!

Name Link
🔨 Latest commit 849ca72
🔍 Latest deploy log https://app.netlify.com/projects/loadsmart-engineering/deploys/6a43dbec52d204000899e3e6
😎 Deploy Preview https://deploy-preview-80--loadsmart-engineering.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@gatsby-config.js`:
- Around line 87-90: The Google Fonts request in the Gatsby config is missing
the 400 weight for Plus Jakarta Sans, so normal body text cannot load the
intended face. Update the fonts entry in the Gatsby config’s fonts array to
include the 400 weight alongside the existing Plus Jakarta Sans weights, keeping
the request consistent with the body copy’s font-weight 400.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: loadsmart/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e3a1cbac-f160-445e-9fc4-5323eac3b530

📥 Commits

Reviewing files that changed from the base of the PR and between a0e8552 and 513413f.

⛔ Files ignored due to path filters (16)
  • src/styles/fonts/SharpSans-Bold.eot is excluded by !**/*.eot
  • src/styles/fonts/SharpSans-Bold.woff is excluded by !**/*.woff
  • src/styles/fonts/SharpSans-Bold.woff2 is excluded by !**/*.woff2
  • src/styles/fonts/SharpSans-Book.eot is excluded by !**/*.eot
  • src/styles/fonts/SharpSans-Book.woff is excluded by !**/*.woff
  • src/styles/fonts/SharpSans-Book.woff2 is excluded by !**/*.woff2
  • src/styles/fonts/SharpSans-Light.eot is excluded by !**/*.eot
  • src/styles/fonts/SharpSans-Light.woff is excluded by !**/*.woff
  • src/styles/fonts/SharpSans-Light.woff2 is excluded by !**/*.woff2
  • src/styles/fonts/SharpSans-Medium.eot is excluded by !**/*.eot
  • src/styles/fonts/SharpSans-Medium.woff is excluded by !**/*.woff
  • src/styles/fonts/SharpSans-Medium.woff2 is excluded by !**/*.woff2
  • src/styles/fonts/SharpSans-Semibold.eot is excluded by !**/*.eot
  • src/styles/fonts/SharpSans-Semibold.woff is excluded by !**/*.woff
  • src/styles/fonts/SharpSans-Semibold.woff2 is excluded by !**/*.woff2
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (6)
  • gatsby-config.js
  • package.json
  • src/components/Layout.js
  • src/components/Title.js
  • src/styles/theme.js
  • src/styles/typography.css
💤 Files with no reviewable changes (3)
  • src/styles/typography.css
  • src/components/Layout.js
  • package.json

Comment thread gatsby-config.js Outdated
Comment thread src/styles/theme.js Outdated
Comment thread gatsby-config.js Outdated
@rodsenra
rodsenra self-requested a review June 30, 2026 19:41

@rodsenra rodsenra left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhayasidajr
rhayasidajr merged commit 3642ef6 into main Jun 30, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants